netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Magnus Karlsson <magnus.karlsson@intel.com>,
	nex.sw.ncis.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org,
	netdev@vger.kernel.org, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 6/7] page_pool: check for DMA sync shortcut earlier
Date: Fri, 26 Apr 2024 07:02:29 +0200	[thread overview]
Message-ID: <20240426050229.GA4548@lst.de> (raw)
In-Reply-To: <81df4e0f-07f3-40f6-8d71-ffad791ab611@intel.com>

On Wed, Apr 24, 2024 at 10:52:49AM +0200, Alexander Lobakin wrote:
> Breh, this breaks builds on !DMA_NEED_SYNC systems, as this function
> isn't defined there, and my CI didn't catch it in time... I'll ifdef
> this in the next spin after some reviews for this one.

I looked over the dma-mapping parts of the series and it looks fine
to me.  So please resend as the fixed up version as soon as you fine
time for it.


  reply	other threads:[~2024-04-26  5:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 13:58 [PATCH net-next v4 0/7] dma: skip calling no-op sync ops when possible Alexander Lobakin
2024-04-23 13:58 ` [PATCH net-next v4 1/7] dma: compile-out DMA sync op calls when not used Alexander Lobakin
2024-04-23 13:58 ` [PATCH net-next v4 2/7] dma: avoid redundant calls for sync operations Alexander Lobakin
2024-04-23 13:58 ` [PATCH net-next v4 3/7] iommu/dma: avoid expensive indirect " Alexander Lobakin
2024-04-23 13:58 ` [PATCH net-next v4 4/7] page_pool: make sure frag API fields don't span between cachelines Alexander Lobakin
2024-04-23 13:58 ` [PATCH net-next v4 5/7] page_pool: don't use driver-set flags field directly Alexander Lobakin
2024-04-23 13:58 ` [PATCH net-next v4 6/7] page_pool: check for DMA sync shortcut earlier Alexander Lobakin
2024-04-24  8:52   ` Alexander Lobakin
2024-04-26  5:02     ` Christoph Hellwig [this message]
2024-05-02  5:58       ` Christoph Hellwig
2024-05-06  9:38         ` Alexander Lobakin
2024-05-06  9:43           ` Christoph Hellwig
2024-05-02 15:49     ` Robin Murphy
2024-05-06  9:40       ` Alexander Lobakin
2024-04-23 13:58 ` [PATCH net-next v4 7/7] xsk: use generic DMA sync shortcut instead of a custom one Alexander Lobakin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240426050229.GA4548@lst.de \
    --to=hch@lst.de \
    --cc=aleksander.lobakin@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).