From: kernel test robot <lkp@intel.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>, netdev@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Florian Fainelli <florian.fainelli@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: dsa: Remove adjust_link paths
Date: Fri, 26 Apr 2024 13:20:59 +0800 [thread overview]
Message-ID: <202404261353.mKEFmDUo-lkp@intel.com> (raw)
In-Reply-To: <20240425185336.2084871-3-florian.fainelli@broadcom.com>
Hi Florian,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Florian-Fainelli/net-dsa-Remove-fixed_link_update-member/20240426-025626
base: net-next/main
patch link: https://lore.kernel.org/r/20240425185336.2084871-3-florian.fainelli%40broadcom.com
patch subject: [PATCH net-next 2/2] net: dsa: Remove adjust_link paths
config: arm-defconfig (https://download.01.org/0day-ci/archive/20240426/202404261353.mKEFmDUo-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240426/202404261353.mKEFmDUo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404261353.mKEFmDUo-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/dsa/port.c:1600:21: warning: variable 'phydev' set but not used [-Wunused-but-set-variable]
struct phy_device *phydev = NULL;
^
1 warning generated.
vim +/phydev +1600 net/dsa/port.c
dd805cf3e80e03 Russell King (Oracle 2023-05-25 1594)
8ae674964e67eb Florian Fainelli 2019-12-16 1595 static void dsa_port_phylink_mac_link_down(struct phylink_config *config,
77373d49de22e8 Ioana Ciornei 2019-05-28 1596 unsigned int mode,
77373d49de22e8 Ioana Ciornei 2019-05-28 1597 phy_interface_t interface)
77373d49de22e8 Ioana Ciornei 2019-05-28 1598 {
dd0c9855b41310 Russell King (Oracle 2024-04-10 1599) struct dsa_port *dp = dsa_phylink_to_port(config);
0e27921816ad99 Ioana Ciornei 2019-05-28 @1600 struct phy_device *phydev = NULL;
77373d49de22e8 Ioana Ciornei 2019-05-28 1601 struct dsa_switch *ds = dp->ds;
77373d49de22e8 Ioana Ciornei 2019-05-28 1602
57d77986e74287 Vladimir Oltean 2021-10-20 1603 if (dsa_port_is_user(dp))
6ca80638b90cec Florian Fainelli 2023-10-23 1604 phydev = dp->user->phydev;
0e27921816ad99 Ioana Ciornei 2019-05-28 1605
d074ebf637f87c Florian Fainelli 2024-04-25 1606 if (!ds->ops->phylink_mac_link_down)
77373d49de22e8 Ioana Ciornei 2019-05-28 1607 return;
77373d49de22e8 Ioana Ciornei 2019-05-28 1608
77373d49de22e8 Ioana Ciornei 2019-05-28 1609 ds->ops->phylink_mac_link_down(ds, dp->index, mode, interface);
77373d49de22e8 Ioana Ciornei 2019-05-28 1610 }
77373d49de22e8 Ioana Ciornei 2019-05-28 1611
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-04-26 5:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 18:53 [PATCH net-next 0/2] net: dsa: adjust_link removal Florian Fainelli
2024-04-25 18:53 ` [PATCH net-next 1/2] net: dsa: Remove fixed_link_update member Florian Fainelli
2024-04-25 18:53 ` [PATCH net-next 2/2] net: dsa: Remove adjust_link paths Florian Fainelli
2024-04-26 5:20 ` kernel test robot [this message]
2024-04-26 2:27 ` [PATCH net-next 0/2] net: dsa: adjust_link removal Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404261353.mKEFmDUo-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).