Re: [PATCH v4 net-next v4 2/6] net: add support for segmenting TCP fraglist GSO packets

Paolo Abeni
2024-04-30T10:24:02Z

On Sat, 2024-04-27 at 20:22 +0200, Felix Fietkau wrote:
> @@ -37,6 +101,9 @@ static struct sk_buff *tcp4_gso_segment(struct sk_buff *skb,
> if (!pskb_may_pull(skb, sizeof(struct tcphdr)))
> return ERR_PTR(-EINVAL);
>
> + if (skb_shinfo(skb)->gso_type & SKB_GSO_FRAGLIST)
> + return __tcp4_gso_segment_list(skb, features);

I'm sorry for the incremental feedback, I almost forgot.

Possibly the above condition could deserve an unlikely() annotation?
less relevant than for GRO case, but at least we have consistent
handling of such flag.

Thanks!

Paolo