From: Jakub Kicinski <kuba@kernel.org>
To: Magnus Karlsson <magnus.karlsson@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
ast@kernel.org, andrii@kernel.org, martin.lau@linux.dev,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: pull-request: bpf-next 2024-04-29
Date: Tue, 30 Apr 2024 06:45:08 -0700 [thread overview]
Message-ID: <20240430064508.13fa79a3@kernel.org> (raw)
In-Reply-To: <CAJ8uoz3jzO=nRTRH9OPjTu0iBn9Gdjn0pbgVGdjDKbV=Q_BUMg@mail.gmail.com>
On Tue, 30 Apr 2024 10:16:33 +0200 Magnus Karlsson wrote:
> > Could you follow up to remove this header?
> > Having to keep multiple headers in sync is annoying, and using
> > 'make headers' or including in-tree headers directly is not rocket
> > science.
>
> Just because I am curious, what was the reason/history behind the
> tools/include directory to start with? Most headers seem to be copies
> there.
I think it started as folks copying a handful of headers for perf tool
and snowballed from there. By the time I pulled this the copy of
ethtool.h was already out of date. So is if_xdp.h, BTW, as I am
reminded every time I built networking selftests.
next prev parent reply other threads:[~2024-04-30 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 13:16 pull-request: bpf-next 2024-04-29 Daniel Borkmann
2024-04-29 20:22 ` Jakub Kicinski
2024-04-29 21:14 ` Daniel Borkmann
2024-04-30 8:03 ` Vyavahare, Tushar
2024-04-30 8:16 ` Magnus Karlsson
2024-04-30 13:45 ` Jakub Kicinski [this message]
2024-04-29 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430064508.13fa79a3@kernel.org \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=magnus.karlsson@gmail.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).