From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew.gospodarek@broadcom.com,
David Wei <dw@davidwei.uk>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>
Subject: Re: [PATCH net-next 1/7] bnxt_en: Fix and simplify bnxt_get_avail_msix() calls
Date: Tue, 30 Apr 2024 16:44:09 -0700 [thread overview]
Message-ID: <20240430164409.1c8ff441@kernel.org> (raw)
In-Reply-To: <CACKFLi=K4zOMFHiSsh7A_T846MmPD=puxa2wU_1SbDstF4tJ7Q@mail.gmail.com>
On Tue, 30 Apr 2024 16:35:51 -0700 Michael Chan wrote:
> > On Tue, 30 Apr 2024 15:44:32 -0700 Michael Chan wrote:
> > > Reported-by: David Wei <dw@davidwei.uk>
> > > Fixes: d630624ebd70 ("bnxt_en: Utilize ulp client resources if RoCE is not registered")
> >
> > He hasn't reported it, he sent you a patch.
> > And instead of giving him feedback you posted your own fix.
> > Why?
> > This sort of behavior is really discouraging to contributors.
>
> Sorry, I wanted to get this fixed ASAP and did not quite understand
> the subtlety on how to handle this properly. I will work with David
> to get the fix in.
Thank you, feel free to repost the other 6 patches without the 24h wait.
next prev parent reply other threads:[~2024-04-30 23:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 22:44 [PATCH net-next 0/7] bnxt_en: Updates for net-next Michael Chan
2024-04-30 22:44 ` [PATCH net-next 1/7] bnxt_en: Fix and simplify bnxt_get_avail_msix() calls Michael Chan
2024-04-30 23:19 ` Jakub Kicinski
2024-04-30 23:35 ` Michael Chan
2024-04-30 23:44 ` Jakub Kicinski [this message]
2024-04-30 22:44 ` [PATCH net-next 2/7] bnxt_en: share NQ ring sw_stats memory with subrings Michael Chan
2024-04-30 22:44 ` [PATCH net-next 3/7] bnxt_en: Don't support offline self test when RoCE driver is loaded Michael Chan
2024-04-30 22:44 ` [PATCH net-next 4/7] bnxt_en: Don't call ULP_STOP/ULP_START during L2 reset Michael Chan
2024-04-30 22:44 ` [PATCH net-next 5/7] bnxt_en: Add a mutex to synchronize ULP operations Michael Chan
2024-04-30 22:44 ` [PATCH net-next 6/7] bnxt_en: Optimize recovery path ULP locking in the driver Michael Chan
2024-04-30 22:44 ` [PATCH net-next 7/7] bnxt_en: Add VF PCI ID for 5760X (P7) chips Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430164409.1c8ff441@kernel.org \
--to=kuba@kernel.org \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).