From: Simon Horman <horms@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
"Vitaly Lifshits" <vitaly.lifshits@intel.com>,
regressions@leemhuis.info, stable@vger.kernel.org,
"Jérôme Carretero" <cJ@zougloub.eu>,
"Sasha Neftin" <sasha.neftin@intel.com>,
"Dima Ruinskiy" <dima.ruinskiy@intel.com>
Subject: Re: [PATCH net] e1000e: change usleep_range to udelay in PHY mdic access
Date: Tue, 30 Apr 2024 18:31:31 +0100 [thread overview]
Message-ID: <20240430173131.GA2575892@kernel.org> (raw)
In-Reply-To: <20240429171040.1152516-1-anthony.l.nguyen@intel.com>
On Mon, Apr 29, 2024 at 10:10:40AM -0700, Tony Nguyen wrote:
> From: Vitaly Lifshits <vitaly.lifshits@intel.com>
>
> This is a partial revert of commit 6dbdd4de0362 ("e1000e: Workaround
> for sporadic MDI error on Meteor Lake systems"). The referenced commit
> used usleep_range inside the PHY access routines, which are sometimes
> called from an atomic context. This can lead to a kernel panic in some
> scenarios, such as cable disconnection and reconnection on vPro systems.
>
> Solve this by changing the usleep_range calls back to udelay.
>
> Fixes: 6dbdd4de0362 ("e1000e: Workaround for sporadic MDI error on Meteor Lake systems")
> Cc: stable@vger.kernel.org
> Reported-by: Jérôme Carretero <cJ@zougloub.eu>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218740
> Closes: https://lore.kernel.org/lkml/a7eb665c74b5efb5140e6979759ed243072cb24a.camel@zougloub.eu/
> Co-developed-by: Sasha Neftin <sasha.neftin@intel.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
> Tested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-04-30 17:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 17:10 [PATCH net] e1000e: change usleep_range to udelay in PHY mdic access Tony Nguyen
2024-04-30 17:31 ` Simon Horman [this message]
2024-05-01 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430173131.GA2575892@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=cJ@zougloub.eu \
--cc=davem@davemloft.net \
--cc=dima.ruinskiy@intel.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@leemhuis.info \
--cc=sasha.neftin@intel.com \
--cc=stable@vger.kernel.org \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).