From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Heng Qi <hengqi@linux.alibaba.com>,
netdev@vger.kernel.org, jgg@nvidia.com, leonro@nvidia.com,
Andrew Morton <akpm@linux-foundation.org>,
Tal Gilboa <talgi@nvidia.com>,
"open list:LIBRARY CODE" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] lib: Allow for the DIM library to be modular
Date: Fri, 3 May 2024 14:36:54 -0700 [thread overview]
Message-ID: <20240503143654.6843f43e@kernel.org> (raw)
In-Reply-To: <60ac51d1-da8a-4108-97c0-2d1ca8dc997e@broadcom.com>
On Thu, 2 May 2024 20:19:27 -0700 Florian Fainelli wrote:
> Looking at "[PATCH net-next v11 0/4] ethtool: provide the dim profile
> fine-tuning channel" it seems like Heng took care of making all of the
> newly added functions EXPORT_SYMBOL(). The only thing I see missing is a
> "select DIMLIB" from config ETHTOOL_NETLINK, do you see something else?
I think we refer to the default DIM tables from net/core/ to clone
them at init time. But we can move the init function into DIM itself.
That's probably for the better.
next prev parent reply other threads:[~2024-05-03 21:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 0:25 [PATCH net-next] lib: Allow for the DIM library to be modular Florian Fainelli
2024-05-03 0:58 ` Jakub Kicinski
2024-05-03 3:19 ` Florian Fainelli
2024-05-03 21:36 ` Jakub Kicinski [this message]
2024-05-04 20:16 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240503143654.6843f43e@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=florian.fainelli@broadcom.com \
--cc=hengqi@linux.alibaba.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=talgi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).