* [PATCH v1 10/12] sfc: falcon: Make I2C terminology more inclusive [not found] <20240430173812.1423757-1-eahariha@linux.microsoft.com> @ 2024-04-30 17:38 ` Easwar Hariharan 2024-05-03 22:13 ` Jakub Kicinski 0 siblings, 1 reply; 3+ messages in thread From: Easwar Hariharan @ 2024-04-30 17:38 UTC (permalink / raw) To: Edward Cree, Martin Habets, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, Easwar Hariharan, Simon Horman, open list:SFC NETWORK DRIVER, open list:SFC NETWORK DRIVER, open list Cc: Wolfram Sang, open list:RADEON and AMDGPU DRM DRIVERS, open list:DRM DRIVERS, open list, open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS, open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS, open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS, open list:I2C SUBSYSTEM HOST DRIVERS, open list:BTTV VIDEO4LINUX DRIVER, open list:FRAMEBUFFER LAYER I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/ Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> Reviewed-by: Simon Horman <horms@kernel.org> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> --- drivers/net/ethernet/sfc/falcon/falcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/falcon/falcon.c b/drivers/net/ethernet/sfc/falcon/falcon.c index 7a1c9337081b..36114ce88034 100644 --- a/drivers/net/ethernet/sfc/falcon/falcon.c +++ b/drivers/net/ethernet/sfc/falcon/falcon.c @@ -367,7 +367,7 @@ static const struct i2c_algo_bit_data falcon_i2c_bit_operations = { .getsda = falcon_getsda, .getscl = falcon_getscl, .udelay = 5, - /* Wait up to 50 ms for slave to let us pull SCL high */ + /* Wait up to 50 ms for target to let us pull SCL high */ .timeout = DIV_ROUND_UP(HZ, 20), }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 10/12] sfc: falcon: Make I2C terminology more inclusive 2024-04-30 17:38 ` [PATCH v1 10/12] sfc: falcon: Make I2C terminology more inclusive Easwar Hariharan @ 2024-05-03 22:13 ` Jakub Kicinski 2024-05-06 15:54 ` Easwar Hariharan 0 siblings, 1 reply; 3+ messages in thread From: Jakub Kicinski @ 2024-05-03 22:13 UTC (permalink / raw) To: Easwar Hariharan Cc: Edward Cree, Martin Habets, David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman, open list:SFC NETWORK DRIVER, open list:SFC NETWORK DRIVER, open list, Wolfram Sang, open list:RADEON and AMDGPU DRM DRIVERS, open list:DRM DRIVERS, open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS, open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS, open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS, open list:I2C SUBSYSTEM HOST DRIVERS, open list:BTTV VIDEO4LINUX DRIVER, open list:FRAMEBUFFER LAYER On Tue, 30 Apr 2024 17:38:09 +0000 Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > with more appropriate terms. Inspired by and following on to Wolfram's > series to fix drivers/i2c/[1], fix the terminology for users of > I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists > in the specification. > > Compile tested, no functionality changes intended FWIW we're assuming someone (Wolfram?) will take all of these, instead of area maintainers picking them individually. Please let us know if that's incorrect. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 10/12] sfc: falcon: Make I2C terminology more inclusive 2024-05-03 22:13 ` Jakub Kicinski @ 2024-05-06 15:54 ` Easwar Hariharan 0 siblings, 0 replies; 3+ messages in thread From: Easwar Hariharan @ 2024-05-06 15:54 UTC (permalink / raw) To: Jakub Kicinski Cc: Edward Cree, Martin Habets, David S. Miller, Eric Dumazet, Paolo Abeni, Simon Horman, open list:SFC NETWORK DRIVER, open list:SFC NETWORK DRIVER, open list, Wolfram Sang, open list:RADEON and AMDGPU DRM DRIVERS, open list:DRM DRIVERS, open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS, open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS, open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS, open list:I2C SUBSYSTEM HOST DRIVERS, open list:BTTV VIDEO4LINUX DRIVER, open list:FRAMEBUFFER LAYER On 5/3/2024 3:13 PM, Jakub Kicinski wrote: > On Tue, 30 Apr 2024 17:38:09 +0000 Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" >> with more appropriate terms. Inspired by and following on to Wolfram's >> series to fix drivers/i2c/[1], fix the terminology for users of >> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists >> in the specification. >> >> Compile tested, no functionality changes intended > > FWIW we're assuming someone (Wolfram?) will take all of these, > instead of area maintainers picking them individually. > Please let us know if that's incorrect. I think, based on the trend in the v2 conversation[1], that's correct. If maintainers of other areas disagree, please chime in. Thanks, Easwar [1] https://lore.kernel.org/all/20240503181333.2336999-1-eahariha@linux.microsoft.com/ ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-06 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240430173812.1423757-1-eahariha@linux.microsoft.com>
2024-04-30 17:38 ` [PATCH v1 10/12] sfc: falcon: Make I2C terminology more inclusive Easwar Hariharan
2024-05-03 22:13 ` Jakub Kicinski
2024-05-06 15:54 ` Easwar Hariharan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).