* [PATCH net-next v1 1/1] can: sja1000: plx_pci: Reuse predefined CTI subvendor ID
@ 2024-05-02 12:38 Andy Shevchenko
2024-05-04 9:14 ` Simon Horman
2024-05-05 11:01 ` Marc Kleine-Budde
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2024-05-02 12:38 UTC (permalink / raw)
To: Andy Shevchenko, linux-can, netdev, linux-kernel
Cc: Marc Kleine-Budde, Vincent Mailhol, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
There is predefined PCI_SUBVENDOR_ID_CONNECT_TECH, use it in the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/can/sja1000/plx_pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/can/sja1000/plx_pci.c b/drivers/net/can/sja1000/plx_pci.c
index 5de1ebb0c6f0..67e5316c6372 100644
--- a/drivers/net/can/sja1000/plx_pci.c
+++ b/drivers/net/can/sja1000/plx_pci.c
@@ -122,7 +122,6 @@ struct plx_pci_card {
#define TEWS_PCI_VENDOR_ID 0x1498
#define TEWS_PCI_DEVICE_ID_TMPC810 0x032A
-#define CTI_PCI_VENDOR_ID 0x12c4
#define CTI_PCI_DEVICE_ID_CRG001 0x0900
#define MOXA_PCI_VENDOR_ID 0x1393
@@ -358,7 +357,7 @@ static const struct pci_device_id plx_pci_tbl[] = {
{
/* Connect Tech Inc. CANpro/104-Plus Opto (CRG001) card */
PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
- CTI_PCI_VENDOR_ID, CTI_PCI_DEVICE_ID_CRG001,
+ PCI_SUBVENDOR_ID_CONNECT_TECH, CTI_PCI_DEVICE_ID_CRG001,
0, 0,
(kernel_ulong_t)&plx_pci_card_info_cti
},
--
2.43.0.rc1.1336.g36b5255a03ac
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next v1 1/1] can: sja1000: plx_pci: Reuse predefined CTI subvendor ID
2024-05-02 12:38 [PATCH net-next v1 1/1] can: sja1000: plx_pci: Reuse predefined CTI subvendor ID Andy Shevchenko
@ 2024-05-04 9:14 ` Simon Horman
2024-05-05 11:01 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-05-04 9:14 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-can, netdev, linux-kernel, Marc Kleine-Budde,
Vincent Mailhol, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
On Thu, May 02, 2024 at 03:38:52PM +0300, Andy Shevchenko wrote:
> There is predefined PCI_SUBVENDOR_ID_CONNECT_TECH, use it in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v1 1/1] can: sja1000: plx_pci: Reuse predefined CTI subvendor ID
2024-05-02 12:38 [PATCH net-next v1 1/1] can: sja1000: plx_pci: Reuse predefined CTI subvendor ID Andy Shevchenko
2024-05-04 9:14 ` Simon Horman
@ 2024-05-05 11:01 ` Marc Kleine-Budde
1 sibling, 0 replies; 3+ messages in thread
From: Marc Kleine-Budde @ 2024-05-05 11:01 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-can, netdev, linux-kernel, Vincent Mailhol, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On 02.05.2024 15:38:52, Andy Shevchenko wrote:
> There is predefined PCI_SUBVENDOR_ID_CONNECT_TECH, use it in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to linx-can-next
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-05 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-02 12:38 [PATCH net-next v1 1/1] can: sja1000: plx_pci: Reuse predefined CTI subvendor ID Andy Shevchenko
2024-05-04 9:14 ` Simon Horman
2024-05-05 11:01 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).