From: Simon Horman <horms@kernel.org>
To: Steffen Klassert <steffen.klassert@secunet.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@vger.kernel.org
Subject: Re: [PATCH 0/5] pull request (net-next): ipsec-next 2024-05-03
Date: Sat, 4 May 2024 15:36:57 +0100 [thread overview]
Message-ID: <20240504143657.GA2279@kernel.org> (raw)
In-Reply-To: <20240503082732.2835810-1-steffen.klassert@secunet.com>
On Fri, May 03, 2024 at 10:27:26AM +0200, Steffen Klassert wrote:
> 1) Remove Obsolete UDP_ENCAP_ESPINUDP_NON_IKE Support.
> This was defined by an early version of an IETF draft
> that did not make it to a standard.
>
> 2) Introduce direction attribute for xfrm states.
> xfrm states have a direction, a stsate can be used
> either for input or output packet processing.
> Add a direction to xfrm states to make it clear
> for what a xfrm state is used.
>
> All patches from Antony Antony.
>
> Please pull or let me know if there are problems.
Hi Steffen, all,
This comment is not strictly related to this pull request
and certainly not intended to impede progress of it towards upstream.
However, while looking over it I noticed that Sparse flags a rather
large number of warnings in xfrm code, mostly relating to __rcu annotations.
I'm wondering if, at some point, these could be addressed somehow.
next prev parent reply other threads:[~2024-05-04 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 8:27 [PATCH 0/5] pull request (net-next): ipsec-next 2024-05-03 Steffen Klassert
2024-05-03 8:27 ` [PATCH 1/5] udpencap: Remove Obsolete UDP_ENCAP_ESPINUDP_NON_IKE Support Steffen Klassert
2024-05-07 2:50 ` patchwork-bot+netdevbpf
2024-05-03 8:27 ` [PATCH 2/5] xfrm: Add Direction to the SA in or out Steffen Klassert
2024-05-03 8:27 ` [PATCH 3/5] xfrm: Add dir validation to "out" data path lookup Steffen Klassert
2024-05-03 8:27 ` [PATCH 4/5] xfrm: Add dir validation to "in" " Steffen Klassert
2024-05-03 8:27 ` [PATCH 5/5] xfrm: Restrict SA direction attribute to specific netlink message types Steffen Klassert
2024-05-04 14:36 ` Simon Horman [this message]
2024-05-07 9:00 ` [PATCH 0/5] pull request (net-next): ipsec-next 2024-05-03 Steffen Klassert
2024-05-07 16:54 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504143657.GA2279@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).