From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 5/8] rtnetlink: do not depend on RTNL for many attributes
Date: Sun, 5 May 2024 15:46:08 +0100 [thread overview]
Message-ID: <20240505144608.GB67882@kernel.org> (raw)
In-Reply-To: <20240503192059.3884225-6-edumazet@google.com>
On Fri, May 03, 2024 at 07:20:56PM +0000, Eric Dumazet wrote:
> Following device fields can be read locklessly
> in rtnl_fill_ifinfo() :
>
> type, ifindex, operstate, link_mode, mtu, min_mtu, max_mtu, group,
> promiscuity, allmulti, num_tx_queues, gso_max_segs, gso_max_size,
> gro_max_size, gso_ipv4_max_size, gro_ipv4_max_size, tso_max_size,
> tso_max_segs, num_rx_queues.
Hi Eric,
* Regarding mtu, as the comment you added to sruct net_device
some time ago mentions, mtu is written in many places.
I'm wondering if, in particular wrt ndo_change_mtu implementations,
if some it is appropriate to add WRITE_ONCE() annotations.
* Likewise, is it appropriate to add WRITE_ONCE() to dev_set_group() ?
next prev parent reply other threads:[~2024-05-05 14:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 19:20 [PATCH net-next 0/8] rtnetlink: more rcu conversions for rtnl_fill_ifinfo() Eric Dumazet
2024-05-03 19:20 ` [PATCH net-next 1/8] rtnetlink: do not depend on RTNL for IFLA_QDISC output Eric Dumazet
2024-05-05 14:48 ` Simon Horman
2024-05-03 19:20 ` [PATCH net-next 2/8] rtnetlink: do not depend on RTNL for IFLA_IFNAME output Eric Dumazet
2024-05-05 14:49 ` Simon Horman
2024-05-03 19:20 ` [PATCH net-next 3/8] rtnetlink: do not depend on RTNL for IFLA_TXQLEN output Eric Dumazet
2024-05-05 14:43 ` Simon Horman
2024-05-07 9:26 ` Paolo Abeni
2024-05-07 9:35 ` Eric Dumazet
2024-05-07 16:32 ` Simon Horman
2024-05-03 19:20 ` [PATCH net-next 4/8] net: write once on dev->allmulti and dev->promiscuity Eric Dumazet
2024-05-05 14:54 ` Simon Horman
2024-05-03 19:20 ` [PATCH net-next 5/8] rtnetlink: do not depend on RTNL for many attributes Eric Dumazet
2024-05-05 14:46 ` Simon Horman [this message]
2024-05-05 15:00 ` Eric Dumazet
2024-05-05 15:06 ` Simon Horman
2024-05-05 15:14 ` Eric Dumazet
2024-05-07 16:38 ` Simon Horman
2024-05-07 16:39 ` Eric Dumazet
2024-05-07 16:55 ` Simon Horman
2024-05-03 19:20 ` [PATCH net-next 6/8] rtnetlink: do not depend on RTNL in rtnl_fill_proto_down() Eric Dumazet
2024-05-05 14:52 ` Simon Horman
2024-05-03 19:20 ` [PATCH net-next 7/8] rtnetlink: do not depend on RTNL in rtnl_xdp_prog_skb() Eric Dumazet
2024-05-05 14:53 ` Simon Horman
2024-05-03 19:20 ` [PATCH net-next 8/8] rtnetlink: allow rtnl_fill_link_netnsid() to run under RCU protection Eric Dumazet
2024-05-05 14:54 ` Simon Horman
2024-05-07 9:40 ` [PATCH net-next 0/8] rtnetlink: more rcu conversions for rtnl_fill_ifinfo() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240505144608.GB67882@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).