From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wfout6-smtp.messagingengine.com (wfout6-smtp.messagingengine.com [64.147.123.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B824215A5; Mon, 6 May 2024 14:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.123.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715004341; cv=none; b=NHfCGPqHjSqWObdwpWdKPkubKreJQap33Av6nl9m5EAYilNspZU3HnMTiKk3AkUgbFyF0PRsflh+mZZRXWLYUuUUiD0zSLxUC5u8/bJ7/tk8AHr18EVWXIuaAemt1ZL1JovrS+VHQunMq1WxG98G0uJdQkemlEyIEgIIJJyMl50= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715004341; c=relaxed/simple; bh=kJvurmAd4Huzk7xJLL+fdoKaaexCaT28q6J9IH5vbUY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k63C1EL9fKVjk61Hh0MZ0wRsJ5R7bQXbbH+EynHltbgKNc19iBFlQBwkqVOacJ4AUMeTkhyaKBX0GwXorZcD4t4jh3oAdnv83ag3w828yXToedOiHORsRc7BGPwS3FE18MH0+LObbOl0+hsVZW6id834JybmiuD3wikQgRRspIE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=fp9mKMuN; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=X9VhyV+K; arc=none smtp.client-ip=64.147.123.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="fp9mKMuN"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="X9VhyV+K" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.west.internal (Postfix) with ESMTP id 2831D1C0017D; Mon, 6 May 2024 10:05:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 06 May 2024 10:05:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715004336; x=1715090736; bh=5m5LZqjJlr1xGKll64ocIdbEm6uTXlrNkLO3vlro68Y=; b= fp9mKMuN93Sc0IuPN8x7Yb6mF8aRMErIV9HymDtHmNUVDgBsBhXC4QBQvcYTOL4u cY8actE6R4jd2+OTAr4/OycBLIN+08cGaZa16XUoOsYQnA4VCDlHsCXiRt2P4c0P O1IpCPijtJ0Iu/SdhI9pRDEkSuGEHJV/yFVfHKmxAQlOyctitfwTd1o9TSz3QNut e/z1xGXMLTZisuwhX0VE1xUiQtDRgufsyjnTxmXAa1N2Oo83Zy9dTMTEoPRYKXNK pWCuRVhRPpidJY00UZPuXq+1J61P3YOU7atAL1sz32SEcWhRohXXb4tpQzri7UF5 PtXKJx0s9+GOLCzevmgpVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715004336; x= 1715090736; bh=5m5LZqjJlr1xGKll64ocIdbEm6uTXlrNkLO3vlro68Y=; b=X 9VhyV+KrfZcfqEgHUFjX4gjOzW3SBJPV8NUkQbknlTFklcIkCTJFG78cexMtk44F DmocTDXbCK3YsiDEVhz0GZRmt1Y1WsEy3+MExVNypDtJ2ZS652BJm7o0zNvo5cGb +hJ05tW8Q8mQZV3jAAjEVpmgQxtXpxDM7DNktJ+yQUp3cR4DWcV+fqKuV3UWQUAV nla5ZwIHKBqY9Tnn2W/BYb0TShM8nkRU2Vr/KmMEEoRxNG4QQtrcLtpAN3LM07Cq 8ZEYxlCn0UrvVfFC+LIHgMKpBCLKhMijjZOiSDvWfpAj5AMsr3cUeYC15DFfz+Sk 30qHx6mRhhsJnow2JTlsw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddviedgjedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefpihhk lhgrshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhouggvrhhluhhnugdorhgvnh gvshgrshesrhgrghhnrghtvggthhdrshgvqeenucggtffrrghtthgvrhhnpeefhfellefh ffejgfefudfggeejlefhveehieekhfeulefgtdefueehffdtvdelieenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehnihhklhgrshdrshhouggv rhhluhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthhdrshgv X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 May 2024 10:05:35 -0400 (EDT) Date: Mon, 6 May 2024 16:05:33 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Andrew Lunn Cc: Yoshihiro Shimoda , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [net-next] net: ethernet: rtsn: Add support for Renesas Ethernet-TSN Message-ID: <20240506140533.GD720810@ragnatech.se> References: <20240414135937.1139611-1-niklas.soderlund+renesas@ragnatech.se> <5fd25c58-b421-4ec0-8b4f-24f86f054a44@lunn.ch> <20240503102006.GI3927860@ragnatech.se> <20240503133033.GJ3927860@ragnatech.se> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Andrew, Thanks for this explanation, it helps understand what's going on. On 2024-05-06 03:51:45 +0200, Andrew Lunn wrote: > What PHY is this? Does it have C22 registers? Can it be identified via > C22 registers 2 and 3? The PHY in question is mv88q2110 (drivers/net/phy/marvell-88q2xxx.c), unfortunately I do not have a datasheet for it so I can't tell you much about it. > > So i would drop the compatible. See if C22 is sufficient to get the > correct driver loaded. - Remove C45 compatible; Remove C45 read/write in driver The PHY is identified as "Generic PHY", and the correct PHY driver is not used. I can't test more than that as the generic PHY driver do not implement some quirks I need to get the link up. - Remove C45 compatible; Keep C45 read/write in driver The correct PHY driver is used and everything works. - Keep C45 compatible; Remove C45 read/write in driver As described earlier in this thread, the MAC driver can't connect to the PHY as the call-chain described earlier fails. How would you suggest I move forward here? Shall I keep the C45 over C22 read/write in the driver or can I do something else more clever? -- Kind Regards, Niklas Söderlund