From: Lee Jones <lee@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] ptp: clockmatrix: Start comments with '/*'
Date: Tue, 7 May 2024 09:43:36 +0100 [thread overview]
Message-ID: <20240507084336.GX1227636@google.com> (raw)
In-Reply-To: <20240504-clockmatrix-kernel-doc-v1-1-acb07a33bb17@kernel.org>
Subject line should start with:
"mfd: idt8a340_reg: "
On Sat, 04 May 2024, Simon Horman wrote:
> Several comments in idt8a340_reg.h start with '/**',
> which denotes the start of a Kernel doc,
> but are otherwise not Kernel docs.
Some very odd line breaking here.
> Resolve this conflict by starting these comments with '/*' instead.
>
> Flagged by ./scripts/kernel-doc -none
>
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---
> include/linux/mfd/idt8a340_reg.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/mfd/idt8a340_reg.h b/include/linux/mfd/idt8a340_reg.h
> index 0c706085c205..53a222605526 100644
> --- a/include/linux/mfd/idt8a340_reg.h
> +++ b/include/linux/mfd/idt8a340_reg.h
> @@ -61,7 +61,7 @@
> #define HW_Q8_CTRL_SPARE (0xa7d4)
> #define HW_Q11_CTRL_SPARE (0xa7ec)
>
> -/**
> +/*
> * Select FOD5 as sync_trigger for Q8 divider.
> * Transition from logic zero to one
> * sets trigger to sync Q8 divider.
> @@ -70,7 +70,7 @@
> */
> #define Q9_TO_Q8_SYNC_TRIG BIT(1)
>
> -/**
> +/*
> * Enable FOD5 as driver for clock and sync for Q8 divider.
> * Enable fanout buffer for FOD5.
> *
> @@ -78,7 +78,7 @@
> */
> #define Q9_TO_Q8_FANOUT_AND_CLOCK_SYNC_ENABLE_MASK (BIT(0) | BIT(2))
>
> -/**
> +/*
> * Select FOD6 as sync_trigger for Q11 divider.
> * Transition from logic zero to one
> * sets trigger to sync Q11 divider.
> @@ -87,7 +87,7 @@
> */
> #define Q10_TO_Q11_SYNC_TRIG BIT(1)
>
> -/**
> +/*
> * Enable FOD6 as driver for clock and sync for Q11 divider.
> * Enable fanout buffer for FOD6.
> *
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-05-07 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-04 15:31 [PATCH] ptp: clockmatrix: Start comments with '/*' Simon Horman
2024-05-07 8:43 ` Lee Jones [this message]
2024-05-07 16:49 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507084336.GX1227636@google.com \
--to=lee@kernel.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).