From: Jakub Kicinski <kuba@kernel.org>
To: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
rajesh.sivaramasubramaniom@oracle.com,
rama.nichanamatlu@oracle.com, manjunath.b.patil@oracle.com
Subject: Re: [PATCH v2] net/sched: adjust device watchdog timer to detect stopped queue at right time
Date: Tue, 7 May 2024 17:30:47 -0700 [thread overview]
Message-ID: <20240507173047.47586a14@kernel.org> (raw)
In-Reply-To: <20240506135944.7753-1-praveen.kannoju@oracle.com>
LGTM!
One nit..
On Mon, 6 May 2024 19:29:44 +0530 Praveen Kumar Kannoju wrote:
> + if (time_after(jiffies, (trans_start + dev->watchdog_timeo))) {
^ ^
Would you mind dropping these brackets while you're touching this line?
They are unnecessary.
prev parent reply other threads:[~2024-05-08 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 13:59 [PATCH v2] net/sched: adjust device watchdog timer to detect stopped queue at right time Praveen Kumar Kannoju
2024-05-08 0:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507173047.47586a14@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=manjunath.b.patil@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=praveen.kannoju@oracle.com \
--cc=rajesh.sivaramasubramaniom@oracle.com \
--cc=rama.nichanamatlu@oracle.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).