* [PATCH] net: dccp: Fix ccid2_rtt_estimator() kernel-doc
@ 2024-05-05 20:09 Jeff Johnson
2024-05-07 19:17 ` Simon Horman
2024-05-07 23:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-05-05 20:09 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: dccp, netdev, linux-kernel, Jeff Johnson
make C=1 reports:
warning: Function parameter or struct member 'mrtt' not described in 'ccid2_rtt_estimator'
So document the 'mrtt' parameter.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
net/dccp/ccids/ccid2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c
index 4d9823d6dced..d6b30700af67 100644
--- a/net/dccp/ccids/ccid2.c
+++ b/net/dccp/ccids/ccid2.c
@@ -353,6 +353,7 @@ static void ccid2_hc_tx_packet_sent(struct sock *sk, unsigned int len)
/**
* ccid2_rtt_estimator - Sample RTT and compute RTO using RFC2988 algorithm
* @sk: socket to perform estimator on
+ * @mrtt: measured RTT
*
* This code is almost identical with TCP's tcp_rtt_estimator(), since
* - it has a higher sampling frequency (recommended by RFC 1323),
---
base-commit: 2c4d8e19cf060744a9db466ffbaea13ab37f25ca
change-id: 20240505-ccid2_rtt_estimator-kdoc-7346f82e7afd
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dccp: Fix ccid2_rtt_estimator() kernel-doc
2024-05-05 20:09 [PATCH] net: dccp: Fix ccid2_rtt_estimator() kernel-doc Jeff Johnson
@ 2024-05-07 19:17 ` Simon Horman
2024-05-07 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-05-07 19:17 UTC (permalink / raw)
To: Jeff Johnson
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, dccp,
netdev, linux-kernel
On Sun, May 05, 2024 at 01:09:31PM -0700, Jeff Johnson wrote:
> make C=1 reports:
>
> warning: Function parameter or struct member 'mrtt' not described in 'ccid2_rtt_estimator'
>
> So document the 'mrtt' parameter.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Reviewed-by: Simon Horman <horms@kernel.org>
The comment just inside tcp_rtt_estimator is a good read :)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dccp: Fix ccid2_rtt_estimator() kernel-doc
2024-05-05 20:09 [PATCH] net: dccp: Fix ccid2_rtt_estimator() kernel-doc Jeff Johnson
2024-05-07 19:17 ` Simon Horman
@ 2024-05-07 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-05-07 23:20 UTC (permalink / raw)
To: Jeff Johnson; +Cc: davem, edumazet, kuba, pabeni, dccp, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 5 May 2024 13:09:31 -0700 you wrote:
> make C=1 reports:
>
> warning: Function parameter or struct member 'mrtt' not described in 'ccid2_rtt_estimator'
>
> So document the 'mrtt' parameter.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>
> [...]
Here is the summary with links:
- net: dccp: Fix ccid2_rtt_estimator() kernel-doc
https://git.kernel.org/netdev/net-next/c/feb8c2b76eb3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-07 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-05 20:09 [PATCH] net: dccp: Fix ccid2_rtt_estimator() kernel-doc Jeff Johnson
2024-05-07 19:17 ` Simon Horman
2024-05-07 23:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).