From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next] net: annotate writes on dev->mtu from ndo_change_mtu()
Date: Tue, 7 May 2024 21:07:51 +0100 [thread overview]
Message-ID: <20240507200751.GK15955@kernel.org> (raw)
In-Reply-To: <20240506102812.3025432-1-edumazet@google.com>
On Mon, May 06, 2024 at 10:28:12AM +0000, Eric Dumazet wrote:
> Simon reported that ndo_change_mtu() methods were never
> updated to use WRITE_ONCE(dev->mtu, new_mtu) as hinted
> in commit 501a90c94510 ("inet: protect against too small
> mtu values.")
>
> We read dev->mtu without holding RTNL in many places,
> with READ_ONCE() annotations.
>
> It is time to take care of ndo_change_mtu() methods
> to use corresponding WRITE_ONCE()
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Simon Horman <horms@kernel.org>
> Closes: https://lore.kernel.org/netdev/20240505144608.GB67882@kernel.org/
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-05-07 20:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 10:28 [PATCH net-next] net: annotate writes on dev->mtu from ndo_change_mtu() Eric Dumazet
2024-05-06 22:31 ` Jacob Keller
2024-05-07 10:05 ` Sabrina Dubroca
2024-05-07 20:07 ` Simon Horman [this message]
2024-05-07 22:31 ` Nelson, Shannon
2024-05-07 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507200751.GK15955@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).