From: Jakub Kicinski <kuba@kernel.org>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, jiri@resnulli.us,
horms@kernel.org
Subject: Re: [PATCH net-next v4 1/6] net: tn40xx: add pci driver for Tehuti Networks TN40xx chips
Date: Wed, 8 May 2024 06:49:22 -0700 [thread overview]
Message-ID: <20240508064922.77e4a69a@kernel.org> (raw)
In-Reply-To: <20240508.163618.289658716761599768.fujita.tomonori@gmail.com>
On Wed, 08 May 2024 16:36:18 +0900 (JST) FUJITA Tomonori wrote:
> > On Thu, 2 May 2024 08:05:47 +0900 FUJITA Tomonori wrote:
> >> + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64))) {
> >> + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> >
> > This fallback is unnecessary, please see commit f0ed939b6a or one of
> > many similar removals..
>
> I see, fixed.
>
> It might not be necessary to check the returned value here? I keep the
> checking alone like the majority of drivers though.
Right, keep the error check. It's just that the failure, if it happens,
will not be related to the length of the mask. So "fallback" to 32b if
64b fails is unnecessary.
next prev parent reply other threads:[~2024-05-08 13:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 23:05 [PATCH net-next v4 0/6] add ethernet driver for Tehuti Networks TN40xx chips FUJITA Tomonori
2024-05-01 23:05 ` [PATCH net-next v4 1/6] net: tn40xx: add pci " FUJITA Tomonori
2024-05-07 1:38 ` Jakub Kicinski
2024-05-08 7:36 ` FUJITA Tomonori
2024-05-08 13:49 ` Jakub Kicinski [this message]
2024-05-01 23:05 ` [PATCH net-next v4 2/6] net: tn40xx: add register defines FUJITA Tomonori
2024-05-01 23:05 ` [PATCH net-next v4 3/6] net: tn40xx: add basic Tx handling FUJITA Tomonori
2024-05-07 1:51 ` Jakub Kicinski
2024-05-08 7:41 ` FUJITA Tomonori
2024-05-01 23:05 ` [PATCH net-next v4 4/6] net: tn40xx: add basic Rx handling FUJITA Tomonori
2024-05-06 9:20 ` Paolo Abeni
2024-05-08 7:26 ` FUJITA Tomonori
2024-05-07 1:58 ` Jakub Kicinski
2024-05-08 7:43 ` FUJITA Tomonori
2024-05-01 23:05 ` [PATCH net-next v4 5/6] net: tn40xx: add mdio bus support FUJITA Tomonori
2024-05-01 23:05 ` [PATCH net-next v4 6/6] net: tn40xx: add PHYLIB support FUJITA Tomonori
2024-05-08 12:21 ` Andrew Lunn
2024-05-08 13:18 ` FUJITA Tomonori
2024-05-08 14:03 ` Andrew Lunn
2024-05-09 4:23 ` FUJITA Tomonori
2024-05-09 13:37 ` Andrew Lunn
2024-05-12 5:20 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508064922.77e4a69a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=fujita.tomonori@gmail.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).