From: Jakub Kicinski <kuba@kernel.org>
To: "Arinzon, David" <darinzon@amazon.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Woodhouse, David" <dwmw@amazon.co.uk>,
"Machulsky, Zorik" <zorik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Wilson, Matt" <msw@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Bshara, Nafea" <nafea@amazon.com>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Itzko, Shahar" <itzko@amazon.com>,
"Abboud, Osama" <osamaabb@amazon.com>,
"Ostrovsky, Evgeny" <evostrov@amazon.com>,
"Tabachnik, Ofir" <ofirt@amazon.com>
Subject: Re: [PATCH v1 net-next 6/6] net: ena: Add a field for no interrupt moderation update action
Date: Wed, 8 May 2024 08:33:17 -0700 [thread overview]
Message-ID: <20240508083317.62897ef1@kernel.org> (raw)
In-Reply-To: <6f5415915976495f8252411c317aedbb@amazon.com>
On Wed, 8 May 2024 05:55:50 +0000 Arinzon, David wrote:
> This is a true/false indicator, it doesn't require history/previous value to be considered.
> Therefore, not sure I see the how |= can help us in the logic here.
> The flag is set here to true if during the interrupt moderation update, which is, in this flow,
> triggered by an ethtool operation, the moderation value has changed from the currently
> configurated one.
I couldn't locate an immediate application of the new value in
the ethtool flow. So the question is whether the user can call
update back to back, with the same settings. First time flag
would be set and second time cleared.
Also the whole thing appears to be devoid of locking or any
consideration of concurrency.
next prev parent reply other threads:[~2024-05-08 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 7:04 [PATCH v1 net-next 0/6] ENA driver changes May 2024 darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 1/6] net: ena: Add a counter for driver's reset failures darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 2/6] net: ena: Reduce holes in ena_com structures darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 3/6] net: ena: Add validation for completion descriptors consistency darinzon
2024-05-08 2:33 ` Jakub Kicinski
2024-05-08 6:01 ` Arinzon, David
2024-05-06 7:04 ` [PATCH v1 net-next 4/6] net: ena: Changes around strscpy calls darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 5/6] net: ena: Change initial rx_usec interval darinzon
2024-05-06 7:04 ` [PATCH v1 net-next 6/6] net: ena: Add a field for no interrupt moderation update action darinzon
2024-05-08 2:31 ` Jakub Kicinski
2024-05-08 5:55 ` Arinzon, David
2024-05-08 15:33 ` Jakub Kicinski [this message]
2024-05-09 7:25 ` Arinzon, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508083317.62897ef1@kernel.org \
--to=kuba@kernel.org \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=darinzon@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=evostrov@amazon.com \
--cc=itzko@amazon.com \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=ndagan@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=ofirt@amazon.com \
--cc=osamaabb@amazon.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).