From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 411E65820C for ; Wed, 8 May 2024 12:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715172050; cv=none; b=mYIvixd+j9mwdrmeegyLztzjBM8jzSBRkZXbseLVI/zFzD7TuYjKmxqiEbUykTpkDHkG8AJCyZ+r2l+yNr0gG900DBlv5BpFC5Wy+Zy7fUyh/ns3c9fRa1W47xVtlWfv9O5vQdYY+0uxtwYhibO5XJ/zL1GjxCIySkvNz7IwxNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715172050; c=relaxed/simple; bh=KshEsZ++XPWV2oCFnYNsh6G3XmmGdJOqWAx/1Ec67G0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sWpwPcqgPqOGN6C5da+H4I1ckG7ND+9Z8xzUi89j6n9lmn2q//WO0agnG17U244cEenJ1vBdYxI/mk89DClA5QxSqU9cb1QF7UL01BKB2ihAUz+gNR3bGdf0unbhLO4byVjR7OeHehaj2gNECLbH/uUt/fmjCrCPplhgwWGK4X4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r+Jh7H7/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r+Jh7H7/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E237C113CC; Wed, 8 May 2024 12:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715172049; bh=KshEsZ++XPWV2oCFnYNsh6G3XmmGdJOqWAx/1Ec67G0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r+Jh7H7/tXqnqPZnmNc6Eh3dQ+u1d7s+0Byal7AYzRdePhsClzkl6TzZ0JDkunPXu zBZ/dTq+4OT1FtyebkB6i/xp5Rlc9Ye3u1h0ylLOYxW/DxjXTlvtXkP9E3Ejhv3t4M 15jS4GV591Qdo8ZmREvX95hR8bvuduLfJshcYtYxucQb2MDtUjVVoLt6hEPphY6gQ2 MLca3tkJT3ipqjfw7YE5iv2/fz/+KUIPInRq6A4fBSNSW4RMq8t5HTKaY7XXdeO5mY nVA+fkQ3oTRb1I497GoFIItS7urUBquxcVooU1zHYVBWg6snCDxwfLZIi+GYP9Zk01 y5O4+VFDIqCeA== Date: Wed, 8 May 2024 13:40:46 +0100 From: Simon Horman To: Eric Dumazet Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, eric.dumazet@gmail.com, Remi Denis-Courmont Subject: Re: [PATCH v2 net-next] phonet: no longer hold RTNL in route_dumpit() Message-ID: <20240508124046.GD1736038@kernel.org> References: <20240507121748.416287-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507121748.416287-1-edumazet@google.com> On Tue, May 07, 2024 at 12:17:48PM +0000, Eric Dumazet wrote: > route_dumpit() already relies on RCU, RTNL is not needed. > > Also change return value at the end of a dump. > This allows NLMSG_DONE to be appended to the current > skb at the end of a dump, saving a couple of recvmsg() > system calls. > > Signed-off-by: Eric Dumazet > Cc: Remi Denis-Courmont > --- > v2: break;; -> break; (Jakub) Reviewed-by: Simon Horman