From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C56B338DF2 for ; Wed, 8 May 2024 19:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715198136; cv=none; b=ugoamCaAOZ364JtRG77G3vaV2TyqepgqaRmqY5iBKqG6Ka1Aa8n9kXm/wkmv7fvyuRsGCNB/7hGc8WV9eahjEGjcjoN5qg/3igNUKdlWMZmLaFyuRTIZYZb3HTm2SgRh1r+YYlWorOu7r3rH1b+mJDia2yw81eAFMBx2s+B0I8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715198136; c=relaxed/simple; bh=HqpGS+JOndachOGlFftx2AIMZIuv9uWeH/DA9u9Y/bo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F/lAXAnfxeq7DRAMRqSHBSiypIc1v+YR5JfL6S/qOUcGs09YdS4lhs4qCF+A6MCuMCPr0EDSutJ2QLSX1bKQS6hK64LOl53maEB0qzV2/hKavKI5+4jgSI5NWex62YyVRaYU4UuR8pp+88Erm+OQaXus5GXBR97kOTG2LzcJkgs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cGMGbJ3a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cGMGbJ3a" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9B34C113CC; Wed, 8 May 2024 19:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715198136; bh=HqpGS+JOndachOGlFftx2AIMZIuv9uWeH/DA9u9Y/bo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cGMGbJ3a7KYbRO3B4DJTfpChzOfeNGlsnJPCj141pQJujoFFsQBXmgBeVeXohaDfO LIpQtaxkqF/7ZYQECW8az7n60doEv7xWTDrFab8uYp6P/hrIDkyMjfC7T0NGzXmiMR rOZOOFHqqcsMOWXS6TeDuIRjtxgMgT23TvM57u1rHESH4Fosrm86kpr5vX5xYrMMob XTDwfRDV7xO9U2eZfpmwtEmKK1Xk/r4e5M7J2PoyTtcuhPc9WRrfGW1KjoQvIPqGS2 tUTRDru8vGiBGPJ5/yyhhaa98TB3wm4IsVyd9fQ+iIFfCVDSIIAjm46hUSrHfz0A+C VI1AfNXzEy3dw== Date: Wed, 8 May 2024 20:55:32 +0100 From: Simon Horman To: Eric Dumazet Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Kuniyuki Iwashima , netdev@vger.kernel.org, eric.dumazet@gmail.com Subject: Re: [PATCH net-next] net: annotate data-races around dev->if_port Message-ID: <20240508195532.GI1736038@kernel.org> References: <20240507184144.1230469-1-edumazet@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240507184144.1230469-1-edumazet@google.com> On Tue, May 07, 2024 at 06:41:44PM +0000, Eric Dumazet wrote: > Various ndo_set_config() methods can change dev->if_port > > dev->if_port is going to be read locklessly from > rtnl_fill_link_ifmap(). > > Add corresponding WRITE_ONCE() on writer sides. > > Signed-off-by: Eric Dumazet Reviewed-by: Simon Horman