From: Jakub Kicinski <kuba@kernel.org>
To: Jiawen Wu <jiawenwu@trustnetic.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<rmk+kernel@armlinux.org.uk>, <andrew@lunn.ch>,
<netdev@vger.kernel.org>, <mengyuanlou@net-swift.com>,
<duanqiangwen@net-swift.com>
Subject: Re: [PATCH net v2 1/4] net: wangxun: fix the incorrect display of queue number in statistics
Date: Thu, 9 May 2024 08:19:54 -0700 [thread overview]
Message-ID: <20240509081954.42d71326@kernel.org> (raw)
In-Reply-To: <009c01daa1ba$1986bae0$4c9430a0$@trustnetic.com>
On Thu, 9 May 2024 10:39:22 +0800 Jiawen Wu wrote:
> > The ethtool API fetches the number of stats and the values in an
> > unsafe, non-atomic way. If someone increases the number of queues
> > while someone else is fetching the stats the memory of the latter
> > process will get corrupted. The code is correct as is.
>
> So should we keep the old code, showing stats with fixed maximum
> number of queues?
Yes.
next prev parent reply other threads:[~2024-05-09 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 10:25 [PATCH net v2 0/4] Wangxun fixes Jiawen Wu
2024-04-29 10:25 ` [PATCH net v2 1/4] net: wangxun: fix the incorrect display of queue number in statistics Jiawen Wu
2024-05-01 1:59 ` Jakub Kicinski
2024-05-09 2:39 ` Jiawen Wu
2024-05-09 15:19 ` Jakub Kicinski [this message]
2024-04-29 10:25 ` [PATCH net v2 2/4] net: wangxun: fix to change Rx features Jiawen Wu
2024-05-02 8:36 ` Simon Horman
2024-05-10 1:57 ` Jiawen Wu
2024-04-29 10:25 ` [PATCH net v2 3/4] net: wangxun: match VLAN CTAG and STAG features Jiawen Wu
2024-04-29 16:07 ` Sai Krishna Gajula
2024-05-02 8:29 ` Simon Horman
2024-04-29 10:25 ` [PATCH net v2 4/4] net: txgbe: fix to control VLAN strip Jiawen Wu
2024-05-02 9:25 ` Simon Horman
2024-05-09 3:08 ` Jiawen Wu
2024-05-09 13:38 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509081954.42d71326@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=duanqiangwen@net-swift.com \
--cc=edumazet@google.com \
--cc=jiawenwu@trustnetic.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).