From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, virtualization@lists.linux.dev,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com
Subject: Re: [patch net-next] virtio_net: add support for Byte Queue Limits
Date: Thu, 9 May 2024 10:28:12 -0400 [thread overview]
Message-ID: <20240509102643-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ZjzQTFq5lJIoeSqM@nanopsycho.orion>
On Thu, May 09, 2024 at 03:31:56PM +0200, Jiri Pirko wrote:
> Thu, May 09, 2024 at 02:41:39PM CEST, mst@redhat.com wrote:
> >On Thu, May 09, 2024 at 01:46:15PM +0200, Jiri Pirko wrote:
> >> From: Jiri Pirko <jiri@nvidia.com>
> >>
> >> Add support for Byte Queue Limits (BQL).
> >>
> >> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
> >
> >Can we get more detail on the benefits you observe etc?
> >Thanks!
>
> More info about the BQL in general is here:
> https://lwn.net/Articles/469652/
I know about BQL in general. We discussed BQL for virtio in the past
mostly I got the feedback from net core maintainers that it likely won't
benefit virtio.
So I'm asking, what kind of benefit do you observe?
--
MST
next prev parent reply other threads:[~2024-05-09 14:28 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 11:46 [patch net-next] virtio_net: add support for Byte Queue Limits Jiri Pirko
2024-05-09 12:41 ` Michael S. Tsirkin
2024-05-09 13:31 ` Jiri Pirko
2024-05-09 14:28 ` Michael S. Tsirkin [this message]
2024-05-10 4:25 ` Jason Wang
2024-05-10 10:37 ` Jiri Pirko
2024-05-10 10:52 ` Michael S. Tsirkin
2024-05-10 11:11 ` Jiri Pirko
2024-05-10 11:27 ` Michael S. Tsirkin
2024-05-10 11:36 ` Jiri Pirko
2024-05-15 7:34 ` Jiri Pirko
2024-05-15 8:20 ` Michael S. Tsirkin
2024-05-15 10:12 ` Jiri Pirko
2024-05-15 12:54 ` Jiri Pirko
2024-05-16 4:48 ` Jason Wang
2024-05-16 10:54 ` Jiri Pirko
2024-05-16 12:31 ` Michael S. Tsirkin
2024-05-16 15:25 ` Jiri Pirko
2024-05-16 19:04 ` Michael S. Tsirkin
2024-05-17 7:52 ` Jiri Pirko
[not found] ` <CAA93jw6WanAQrPAFZ1hYVTXuWDwP+4J70LnmPOD2ugNwYK6HMA@mail.gmail.com>
2024-06-06 7:30 ` Jiri Pirko
2024-05-10 4:25 ` Jason Wang
2024-05-10 7:11 ` Heng Qi
2024-05-10 10:35 ` Jiri Pirko
2024-05-20 12:48 ` Jiri Pirko
2024-06-05 11:30 ` Jiri Pirko
2024-06-05 11:42 ` Heng Qi
2024-06-06 0:20 ` Jason Wang
2024-06-06 2:58 ` Jason Xing
2024-06-06 4:25 ` Jason Wang
2024-06-06 6:05 ` Michael S. Tsirkin
2024-06-06 7:56 ` Jason Wang
2024-06-06 13:45 ` Jiri Pirko
2024-06-07 6:25 ` Jason Wang
2024-06-07 6:39 ` Jiri Pirko
2024-06-07 6:43 ` Michael S. Tsirkin
2024-06-07 6:47 ` Jason Wang
2024-06-07 9:57 ` Jiri Pirko
2024-06-07 10:23 ` Michael S. Tsirkin
2024-06-07 11:30 ` Jiri Pirko
2024-06-10 14:18 ` Michael S. Tsirkin
2024-06-17 1:44 ` Jason Wang
2024-06-17 9:30 ` Jiri Pirko
2024-06-17 16:16 ` Michael S. Tsirkin
2024-06-18 1:19 ` Jason Wang
2024-06-18 0:52 ` Jason Wang
2024-06-18 18:23 ` Michael S. Tsirkin
2024-06-17 16:18 ` Michael S. Tsirkin
2024-06-07 11:22 ` Jason Xing
2024-06-06 11:42 ` Jason Xing
2024-06-06 12:00 ` Michael S. Tsirkin
2024-06-06 13:41 ` Jiri Pirko
2024-06-07 6:22 ` Jason Wang
2024-06-07 6:39 ` Michael S. Tsirkin
2024-06-07 6:40 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509102643-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).