From: Jakub Kicinski <kuba@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Erhard Furtner <erhard_f@mailbox.org>,
"robh@kernel.org" <robh@kernel.org>,
"elder@kernel.org" <elder@kernel.org>,
"bhupesh.sharma@linaro.org" <bhupesh.sharma@linaro.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>
Subject: Re: [PATCH net] eth: sungem: remove .ndo_poll_controller to avoid deadlocks
Date: Thu, 9 May 2024 11:51:33 -0700 [thread overview]
Message-ID: <20240509115133.4fe77b2b@kernel.org> (raw)
In-Reply-To: <AM0PR0402MB3891AD9FB1D365D243AFFCF388E62@AM0PR0402MB3891.eurprd04.prod.outlook.com>
On Thu, 9 May 2024 11:10:46 +0000 Wei Fang wrote:
> Thanks for reminder.
> The fec driver should have the same issue, but I don't know much about netpoll,
> is ndo_poll_controller() no needed anymore? so it can be safely deleted from
> device driver?
If the driver uses NAPI for tx completions - implementing
ndo_poll_controller is not necessary.
next prev parent reply other threads:[~2024-05-09 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 13:45 [PATCH net] eth: sungem: remove .ndo_poll_controller to avoid deadlocks Jakub Kicinski
2024-05-08 14:32 ` Eric Dumazet
2024-05-09 11:10 ` Wei Fang
2024-05-09 18:51 ` Jakub Kicinski [this message]
2024-05-11 1:30 ` patchwork-bot+netdevbpf
2024-05-23 23:53 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509115133.4fe77b2b@kernel.org \
--to=kuba@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bhupesh.sharma@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elder@kernel.org \
--cc=erhard_f@mailbox.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).