From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Jurgens <danielj@nvidia.com>
Cc: <netdev@vger.kernel.org>, <mst@redhat.com>, <jasowang@redhat.com>,
<xuanzhuo@linux.alibaba.com>, <virtualization@lists.linux.dev>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<jiri@nvidia.com>
Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake
Date: Thu, 9 May 2024 18:31:02 -0700 [thread overview]
Message-ID: <20240509183102.7c337c2c@kernel.org> (raw)
In-Reply-To: <20240509163216.108665-2-danielj@nvidia.com>
On Thu, 9 May 2024 11:32:15 -0500 Daniel Jurgens wrote:
> diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h
> index cf24f1d9adf8..ccf6976b1693 100644
> --- a/tools/include/uapi/linux/netdev.h
> +++ b/tools/include/uapi/linux/netdev.h
> @@ -164,7 +164,8 @@ enum {
> NETDEV_A_QSTATS_TX_HW_GSO_BYTES,
> NETDEV_A_QSTATS_TX_HW_GSO_WIRE_PACKETS,
> NETDEV_A_QSTATS_TX_HW_GSO_WIRE_BYTES,
> - NETDEV_A_QSTATS_TX_HW_DROP_RATELIMITS,
Looks like an accidental removal?
> + NETDEV_A_QSTATS_TX_STOP,
> + NETDEV_A_QSTATS_TX_WAKE,
Since you'll have to respin let me nit pick on the docs, as I'm hoping
that those will be comprehensible to users not only devs.
> + name: tx-stop
> + doc: |
> + Number of times the tx queue was stopped.
How about:
Number of times driver paused accepting new tx packets
from the stack to this queue, because the queue was full.
Note that if BQL is supported and enabled on the device
the networking stack will avoid queuing a lot of data at once.
> + name: tx-wake
> + doc: |
> + Number of times the tx queue was restarted.
Number of times driver re-started accepting send
requests to this queue from the stack.
next prev parent reply other threads:[~2024-05-10 1:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 16:32 [PATCH net-next 0/2] Add TX stop/wake counters Daniel Jurgens
2024-05-09 16:32 ` [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake Daniel Jurgens
2024-05-09 20:46 ` Andrew Lunn
2024-05-09 21:19 ` Dan Jurgens
2024-05-10 12:58 ` Andrew Lunn
2024-05-10 20:20 ` Dan Jurgens
2024-05-10 20:40 ` Andrew Lunn
2024-05-10 1:31 ` Jakub Kicinski [this message]
2024-05-10 3:37 ` Dan Jurgens
2024-05-09 16:32 ` [PATCH net-next 2/2] virtio_net: Add TX stopped and wake counters Daniel Jurgens
2024-05-10 1:21 ` Xuan Zhuo
2024-05-10 3:35 ` Dan Jurgens
2024-05-10 6:48 ` Xuan Zhuo
2024-05-10 16:56 ` Dan Jurgens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509183102.7c337c2c@kernel.org \
--to=kuba@kernel.org \
--cc=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=jiri@nvidia.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).