From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A26BB13A3E3; Fri, 10 May 2024 01:31:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715304664; cv=none; b=aoQ+Td/3KB2uQDD9c7CpKfmOl3uhjmzrQGlbnL/hx70VkHPO0oZprJi/sxFDhDbgbDEMTJA5BDaD9IzZCwm2lsILMGD4NNGVO2jqDAjoTOWjEIqFi7HMZWw7PSiNAOkqz/Ql8QM1Oii7QGumHgv2qhQ81l6CyIoHTpF2nok9azs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715304664; c=relaxed/simple; bh=5dVzQx35gUbAAlIMFfqYviXSk3Ia0Y2lTQJTkV1hVGY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oBKGy8VLFXmueTxe2rV3qsBqGF+XZ8Cr63dkMXVyXptCGlEo3/r7lun3xp9oEOpckfpMSnohQIy5gDWvVg4GNI8HSPUlXYwjdDvouefM32U2KCRBpGPGkdhgB+RyhULysAvDbK3OeUalKU1AtoEUQFzM2tecX9KikuJpyAoWclI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XxIKFcmT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XxIKFcmT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0BEAC116B1; Fri, 10 May 2024 01:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715304664; bh=5dVzQx35gUbAAlIMFfqYviXSk3Ia0Y2lTQJTkV1hVGY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XxIKFcmTAsKdpmrLRvHH+Q83NzQBseEX/Tjhklj+8RPUc00xzy5Qx2qjBTA5iqdfH 1gazVBq6razWM8DSWBemiRbWtIQeJZ0hTqZpIV27GFEkHy91tuQqVxfO3tLLE8DJIs 378nfD929SDHQ4f1579D9wFfA4GecQEKbsHDQRL8sl+UdkQE1Bmxr7PXS2XN6aEcOj 3tes81vRxuvyeNhaiI1kIk8hJey1PJtL/eMn45WR1nFLL7TA/1P8K08TN2u9NPMC5P XAHljLA59cC3lFxo53m7MyzjsSFLpPDyZAR/BEo6B7xcPpL1Nk+DHDii5nvTUu8ff3 /Smw3bNXZstsw== Date: Thu, 9 May 2024 18:31:02 -0700 From: Jakub Kicinski To: Daniel Jurgens Cc: , , , , , , , , Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake Message-ID: <20240509183102.7c337c2c@kernel.org> In-Reply-To: <20240509163216.108665-2-danielj@nvidia.com> References: <20240509163216.108665-1-danielj@nvidia.com> <20240509163216.108665-2-danielj@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 9 May 2024 11:32:15 -0500 Daniel Jurgens wrote: > diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h > index cf24f1d9adf8..ccf6976b1693 100644 > --- a/tools/include/uapi/linux/netdev.h > +++ b/tools/include/uapi/linux/netdev.h > @@ -164,7 +164,8 @@ enum { > NETDEV_A_QSTATS_TX_HW_GSO_BYTES, > NETDEV_A_QSTATS_TX_HW_GSO_WIRE_PACKETS, > NETDEV_A_QSTATS_TX_HW_GSO_WIRE_BYTES, > - NETDEV_A_QSTATS_TX_HW_DROP_RATELIMITS, Looks like an accidental removal? > + NETDEV_A_QSTATS_TX_STOP, > + NETDEV_A_QSTATS_TX_WAKE, Since you'll have to respin let me nit pick on the docs, as I'm hoping that those will be comprehensible to users not only devs. > + name: tx-stop > + doc: | > + Number of times the tx queue was stopped. How about: Number of times driver paused accepting new tx packets from the stack to this queue, because the queue was full. Note that if BQL is supported and enabled on the device the networking stack will avoid queuing a lot of data at once. > + name: tx-wake > + doc: | > + Number of times the tx queue was restarted. Number of times driver re-started accepting send requests to this queue from the stack.