From: Jakub Kicinski <kuba@kernel.org>
To: Geetha sowjanya <gakula@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<sgoutham@marvell.com>, <sbhatta@marvell.com>,
<hkelam@marvell.com>
Subject: Re: [net-next PATCH v4 03/10] octeontx2-pf: Create representor netdev
Date: Thu, 9 May 2024 20:28:08 -0700 [thread overview]
Message-ID: <20240509202808.26e960a7@kernel.org> (raw)
In-Reply-To: <20240507163921.29683-4-gakula@marvell.com>
On Tue, 7 May 2024 22:09:14 +0530 Geetha sowjanya wrote:
> + priv->reps = devm_kcalloc(priv->dev, rep_cnt, sizeof(struct rep_dev *),
> + GFP_KERNEL);
> + if (!priv->reps)
> + return -ENOMEM;
using devm_ here is pointless, the objects are not tied to the lifetime
of the device (there can be created multiple times) and you have to
unregister the netdevs manually, anyway.
next prev parent reply other threads:[~2024-05-10 3:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 16:39 [net-next PATCH v4 00/10] Introduce RVU representors Geetha sowjanya
2024-05-07 16:39 ` [net-next PATCH v4 01/10] octeontx2-pf: Refactoring RVU driver Geetha sowjanya
2024-05-07 16:39 ` [net-next PATCH v4 02/10] octeontx2-pf: RVU representor driver Geetha sowjanya
2024-05-10 3:35 ` Jakub Kicinski
2024-05-13 10:28 ` [EXTERNAL] " Geethasowjanya Akula
2024-05-07 16:39 ` [net-next PATCH v4 03/10] octeontx2-pf: Create representor netdev Geetha sowjanya
2024-05-10 3:28 ` Jakub Kicinski [this message]
2024-05-13 10:35 ` [EXTERNAL] " Geethasowjanya Akula
2024-05-11 14:10 ` Simon Horman
2024-05-13 10:38 ` [EXTERNAL] " Geethasowjanya Akula
2024-05-07 16:39 ` [net-next PATCH v4 04/10] octeontx2-pf: Add basic net_device_ops Geetha sowjanya
2024-05-07 16:39 ` [net-next PATCH v4 05/10] octeontx2-af: Add packet path between representor and VF Geetha sowjanya
2024-05-07 16:39 ` [net-next PATCH v4 06/10] octeontx2-pf: Get VF stats via representor Geetha sowjanya
2024-05-07 16:39 ` [net-next PATCH v4 07/10] octeontx2-pf: Add support to sync link state between representor and VFs Geetha sowjanya
2024-05-07 16:39 ` [net-next PATCH v4 08/10] octeontx2-pf: Configure VF mtu via representor Geetha sowjanya
2024-05-07 16:39 ` [net-next PATCH v4 09/10] octeontx2-pf: Add representors for sdp MAC Geetha sowjanya
2024-05-10 3:32 ` Jakub Kicinski
2024-05-13 10:32 ` [EXTERNAL] " Geethasowjanya Akula
2024-05-07 16:39 ` [net-next PATCH v4 10/10] octeontx2-pf: Add devlink port support Geetha sowjanya
2024-05-10 3:35 ` [net-next PATCH v4 00/10] Introduce RVU representors Jakub Kicinski
2024-05-13 10:31 ` [EXTERNAL] " Geethasowjanya Akula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509202808.26e960a7@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).