From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Eric Dumazet" <edumazet@google.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Woojung Huh" <woojung.huh@microchip.com>,
"Arun Ramadoss" <arun.ramadoss@microchip.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com,
"David Ahern" <dsahern@kernel.org>,
"Simon Horman" <horms@kernel.org>,
"Willem de Bruijn" <willemb@google.com>,
"Søren Andersen" <san@skov.dk>
Subject: Re: [PATCH net-next v2 1/3] net: dsa: microchip: dcb: rename IPV to IPM
Date: Thu, 9 May 2024 20:43:06 -0700 [thread overview]
Message-ID: <20240509204306.1b4e77e5@kernel.org> (raw)
In-Reply-To: <20240509053335.129002-2-o.rempel@pengutronix.de>
On Thu, 9 May 2024 07:33:33 +0200 Oleksij Rempel wrote:
> IPV is added and used term in 802.1Qci PSFP and merged into 802.1Q (from
> 802.1Q-2018) for another functions.
>
> Even it does similar operation holding temporal priority value
> internally (as it is named), because KSZ datasheet doesn't use the term
> of IPV (Internal Priority Value) and avoiding any confusion later when
> PSFP is in the Linux world, it is better to rename IPV to IPM (Internal
> Priority Mapping).
>
> In addition, LAN937x documentation already use IPV for 802.1Qci PSFP
> related functionality.
Transient build failure here:
drivers/net/dsa/microchip/ksz_dcb.c: In function ‘ksz_set_global_dscp_entry’:
drivers/net/dsa/microchip/ksz_dcb.c:323:25: error: ‘ipm’ undeclared (first use in this function); did you mean ‘ipv’?
323 | ipm << shift);
| ^~~
| ipv
--
pw-bot: cr
next prev parent reply other threads:[~2024-05-10 3:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 5:33 [PATCH net-next v2 0/3] net: dsa: microchip: DCB fixes Oleksij Rempel
2024-05-09 5:33 ` [PATCH net-next v2 1/3] net: dsa: microchip: dcb: rename IPV to IPM Oleksij Rempel
2024-05-10 3:43 ` Jakub Kicinski [this message]
2024-05-09 5:33 ` [PATCH net-next v2 2/3] net: dsa: microchip: dcb: add comments for DSCP related functions Oleksij Rempel
2024-05-09 5:33 ` [PATCH net-next v2 3/3] net: dsa: microchip: dcb: set default apptrust to PCP only Oleksij Rempel
2024-05-09 8:15 ` Arun.Ramadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509204306.1b4e77e5@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=san@skov.dk \
--cc=willemb@google.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).