From: Anil Samal <anil.samal@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, --cc=jesse.brandeburg@intel.com,
--cc=leszek.pepiak@intel.com, --cc=przemyslaw.kitszel@intel.com,
--cc=lukasz.czapnik@intel.com, --cc=anthony.l.nguyen@intel.com,
Anil Samal <anil.samal@intel.com>
Subject: [PATCH iwl-next v2 0/3] ice:Support to dump PHY config, FEC
Date: Thu, 9 May 2024 23:50:39 -0700 [thread overview]
Message-ID: <20240510065243.906877-1-anil.samal@intel.com> (raw)
Implementation to dump PHY configuration and FEC statistics to
facilitate link level debugging of customer issues. Implementation has
two parts
a. Serdes equalization
# ethtool -d eth0
Output:
Offset Values
------ ------
0x0000: 00 00 00 00 03 00 00 00 05 00 00 00 01 08 00 40
0x0010: 01 00 00 40 00 00 39 3c 01 00 00 00 00 00 00 00
0x0020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
……
…..
0x01f0: 01 00 00 00 ef be ad de 8f 00 00 00 00 00 00 00
0x0200: 00 00 00 00 ef be ad de 00 00 00 00 00 00 00 00
0x0210: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0220: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0230: 00 00 00 00 00 00 00 00 00 00 00 00 fa ff 00 00
0x0240: 06 00 00 00 03 00 00 00 00 00 00 00 00 00 00 00
0x0250: 0f b0 0f b0 00 00 00 00 00 00 00 00 00 00 00 00
0x0260: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0270: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0280: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x0290: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x02a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x02b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x02c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x02d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x02e0: 00 00 00 00 00 00 00 00 00 00 00 00
Current implementation appends 176 bytes i.e. 44 bytes * 4 serdes lane.
For port with 2 serdes lane, first 88 bytes are valid values and
remaining 88 bytes are filled with zero. Similarly for port with 1
serdes lane, first 44 bytes are valid and remaining 132 bytes are marked
zero.
Each set of serdes equalizer parameter (i.e. set of 44 bytes) follows
below order
a. rx_equalization_pre2
b. rx_equalization_pre1
c. rx_equalization_post1
d. rx_equalization_bflf
e. rx_equalization_bfhf
f. rx_equalization_drate
g. tx_equalization_pre1
h. tx_equalization_pre3
i. tx_equalization_atten
j. tx_equalization_post1
k. tx_equalization_pre2
Where each individual equalizer parameter is of 4 bytes. As ethtool
prints values as individual bytes, for little endian machine these
values will be in reverse byte order.
b. FEC block counts
# ethtool -I --show-fec eth0
Output:
FEC parameters for eth0:
Supported/Configured FEC encodings: Auto RS BaseR
Active FEC encoding: RS
Statistics:
corrected_blocks: 0
uncorrectable_blocks: 0
This series do following:
Patch 1 – Implementation to support user provided flag for side band
queue command.
Patch 2 – Currently driver does not have a way to derive serdes lane
number, pcs quad , pcs port from port number.So we introduced a
mechanism to derive above info.
Ethtool interface extension to include FEC statistics counter.
Patch 3 – Ethtool interface extension to include serdes equalizer
output.
v1 -> V2,
Squashed 4 commit to 3 commit.
Removed extra null check of arguments.
Removed initialization of local variable that are not required.
.../net/ethernet/intel/ice/ice_adminq_cmd.h | 51 ++
drivers/net/ethernet/intel/ice/ice_common.c | 99 +++-
drivers/net/ethernet/intel/ice/ice_common.h | 28 +-
drivers/net/ethernet/intel/ice/ice_ethtool.c | 449 +++++++++++++++++-
drivers/net/ethernet/intel/ice/ice_ethtool.h | 29 ++
.../net/ethernet/intel/ice/ice_hw_autogen.h | 2 +
drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 16 +-
drivers/net/ethernet/intel/ice/ice_type.h | 8 +
8 files changed, 669 insertions(+), 13 deletions(-)
--
2.44.0
next reply other threads:[~2024-05-10 6:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 6:50 Anil Samal [this message]
2024-05-10 6:50 ` [PATCH iwl-next v2 1/3] ice: Extend Sideband Queue command to support dynamic flag Anil Samal
2024-05-11 16:57 ` Simon Horman
2024-05-24 0:43 ` Jacob Keller
2024-05-10 6:50 ` [PATCH iwl-next v2 2/3] ice: Implement driver functionality to dump fec statistics Anil Samal
2024-05-11 16:57 ` Simon Horman
2024-05-10 6:50 ` [PATCH iwl-next v2 3/3] ice: Implement driver functionality to dump serdes equalizer values Anil Samal
2024-05-11 16:56 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510065243.906877-1-anil.samal@intel.com \
--to=anil.samal@intel.com \
--cc=--cc=anthony.l.nguyen@intel.com \
--cc=--cc=jesse.brandeburg@intel.com \
--cc=--cc=leszek.pepiak@intel.com \
--cc=--cc=lukasz.czapnik@intel.com \
--cc=--cc=przemyslaw.kitszel@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).