From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B511BDEF for ; Fri, 10 May 2024 17:45:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715363105; cv=none; b=DUGkI9BCal1BcHaoQdhQgV77aCOaiWs/5aXArrSCl4SHuQBgpeOiqKjRV632zR8EMoejte0aPukIwx4R1bYLBV2oPrwgKNpvwZY3TyKs1bMTmujapUb9+RbjCrVZdUb+3cLuYfrQNcPeecBG4yrnfdYtEHzPz9mso25HcIwQgY4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715363105; c=relaxed/simple; bh=77jCAZN4T1MnK/eg9Dn9s0HYNi5Gbz3bp+wgywtPJ8U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q5L0cIHeYols9wm02m9xLE16euOsUcve4R6divldA+CPxadT8I5Us4HCe4Ml37N+RfARACh+pJr3Zh5GTRSQpPEgvGUOK5+PU6/mHTSZHcnowy1R9az+WlvJn40KypUiCHDhVb3Gem4jWtzzzuqqaCGZHrUxvVoTLTbYjKguDoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jfuFEdBq; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jfuFEdBq" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6f44dd41a5cso2345799b3a.0 for ; Fri, 10 May 2024 10:45:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1715363103; x=1715967903; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RH25751FQUD9IraRYi3Ng4hTjnmqYgAtJrim8UnR4Lw=; b=jfuFEdBq40eHLbgJonwdgyHWGexUVHfl/U2WW3h9qOJOjLZNjcnA4rmlz3LsW3PY9l lLHdaQ/U7kZ89eZzT6755BvDnteknBtwwOq7Ax64FoSWW4B+//LtSTSThtqsdIR8FVtB 2SCa3WkY0z3T2hVv21Ck9YMQUsl+7up5H4s4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715363103; x=1715967903; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RH25751FQUD9IraRYi3Ng4hTjnmqYgAtJrim8UnR4Lw=; b=kwTbBkMcjar+0gu9J+kvWVqvux/BZeycpUNtD4RuMDeTJk6kllLCW+H6rrkm7HzHze 6ZTfwq+No6vjluwDdgovMEVLq9/fkEui1Q/2bDxT93KoCLCLwuXH6o1rK2dkcLyYoxoQ +UjvLMg4hXclD/tc34LnxJd5cq/psVg8OpBNVUv9m/fqIvPhUGUVnb35iwYHuIPK8Mxs ftC6dDOO228G+27Z5ghlqPhEZcRFxE8HoEh+owEd2GCD20TvakecQZFgV5PWaCfn4EXw 0rsgA4dw1z0mgpR7Mnl98PeeZ1IbmywZKQ5y8HegOOA2E53/3it24NrNDKt7pewLV/fJ GfAw== X-Forwarded-Encrypted: i=1; AJvYcCV4eeSq7zpGmGX4SVdQaJG8ZAsjoKb+KK+uWaJkysvSbNYUnnpp8cE71g8AxWKxBgAxCznE85ftsygYUmyI36UhgGBkM/fg X-Gm-Message-State: AOJu0Yxq4Pn2kOqtaxrUpn2e4d0W1gezyp2l1GxafTVtzpOHTy2O9Lw3 UqOQPMZtozG4npBuJeYb859t0K639P5PNaNGlA5ZHmX/RthRmX8ecWAWRAy+4w== X-Google-Smtp-Source: AGHT+IGGFWmKinmr/BozpgZxQxrIJHVGNpMfgrtBUBSomrJR7j5qbTiNJokxk2pPxp48vFhrBfY0LA== X-Received: by 2002:a05:6a21:3405:b0:1a8:e79a:2b0a with SMTP id adf61e73a8af0-1afddf036eemr3785881637.0.1715363103156; Fri, 10 May 2024 10:45:03 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6341134706asm2937275a12.86.2024.05.10.10.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 10:45:02 -0700 (PDT) Date: Fri, 10 May 2024 10:45:02 -0700 From: Kees Cook To: Edward Liaw Cc: shuah@kernel.org, =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , =?iso-8859-1?Q?G=FCnther?= Noack , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andy Lutomirski , Will Drewry , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, John Hubbard , Muhammad Usama Anjum Subject: Re: [PATCH v4 55/66] selftests/seccomp: Drop define _GNU_SOURCE Message-ID: <202405101044.DB260BB@keescook> References: <20240510000842.410729-1-edliaw@google.com> <20240510000842.410729-56-edliaw@google.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510000842.410729-56-edliaw@google.com> On Fri, May 10, 2024 at 12:07:12AM +0000, Edward Liaw wrote: > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent > redefinition warnings. > > Reviewed-by: John Hubbard > Reviewed-by: Muhammad Usama Anjum > Signed-off-by: Edward Liaw Acked-by: Kees Cook -- Kees Cook