From: Florian Westphal <fw@strlen.de>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Florian Westphal <fw@strlen.de>, Simon Horman <horms@kernel.org>,
Hangbin Liu <liuhangbin@gmail.com>,
Jaehee Park <jhpark1013@gmail.com>,
Petr Machata <petrm@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>,
Davide Caratti <dcaratti@redhat.com>,
Matthieu Baerts <matttbe@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [TEST] Flake report
Date: Fri, 10 May 2024 18:41:47 +0200 [thread overview]
Message-ID: <20240510164147.GE16079@breakpoint.cc> (raw)
In-Reply-To: <20240510090336.54180074@kernel.org>
Jakub Kicinski <kuba@kernel.org> wrote:
> M. Looks like that didn't do anything.
>
> I tried to investigate nft_audit.sh
>
> https://netdev-3.bots.linux.dev/vmksft-nf/results/589221/22-nft-audit-sh/stdout
>
> # selftests: net/netfilter: nft_audit.sh
> # SKIP: nft reset feature test failed: nftables v1.0.9 (Old Doc Yak #3)
> ok 1 selftests: net/netfilter: nft_audit.sh # SKIP
>
> This is what it hits:
>
> bash-5.2# nft -v
> nftables v1.0.9 (Old Doc Yak #3)
> bash-5.2# nft --check -f /dev/stdin <<EOF
> add table t
> add chain t c
> reset rules t c
> EOF
> /dev/stdin:3:7-11: Error: syntax error, unexpected string, expecting counter or counters or quotas or quota
> reset rules t c
> ^^^^^
>
> What does that mean in lay terms?
This nft version chokes on syntax, but I cannot reproduce this:
src/nft --check -f /dev/stdin <<EOF
add table t
add chain t c
reset rules t c
EOF
echo $?
table ip t {
chain c { }
}
0
src/nft --version
nftables v1.0.9 (Old Doc Yak #3)
No idea :-(
I tried building both recent nftables.git and v1.0.9 tag and both
parse the test file for me :-(
Also. nft-flowtable.sh is still not working on nf infra even
with the updated version while that script works fine locally for me
as well, even with running via vng.
Maybe there is an old libnftables on the system that is used
instead for parsing? Its bundled/installed with nftables, can
you check that ldd nft doesnt show some other distro-installed
version? Other than that I have no idea what could be happening here.
> Question #2, for the ebtables test - do I need to build iptables?
> I built nft with
> ./configure --with-json --with-xtables
You need to add --enable-nftables for ebtables-nft, or you need to
use the old ebtables tree, i.e.:
https://git.netfilter.org/ebtables/
both should work.
next prev parent reply other threads:[~2024-05-10 16:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 23:09 [TEST] Flake report Jakub Kicinski
2024-05-10 3:24 ` Hangbin Liu
2024-05-10 8:35 ` Florian Westphal
2024-05-10 14:47 ` Jakub Kicinski
2024-05-10 16:03 ` Jakub Kicinski
2024-05-10 16:41 ` Florian Westphal [this message]
2024-05-10 18:02 ` Jakub Kicinski
2024-05-11 0:14 ` Jakub Kicinski
2024-05-11 6:50 ` Florian Westphal
2024-05-10 14:28 ` Matthieu Baerts
2024-05-30 17:35 ` Matthieu Baerts
2024-05-30 17:41 ` Jakub Kicinski
2024-05-31 7:52 ` Matthieu Baerts
2024-05-10 14:45 ` Nikolay Aleksandrov
2024-05-11 13:27 ` Simon Horman
2024-05-14 13:52 ` Aaron Conole
2024-05-13 11:58 ` Davide Caratti
2024-05-13 16:52 ` Petr Machata
2024-05-14 13:43 ` Jakub Kicinski
2024-05-21 16:29 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510164147.GE16079@breakpoint.cc \
--to=fw@strlen.de \
--cc=dcaratti@redhat.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jhpark1013@gmail.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).