Re: [PATCH iwl-next v2 3/3] ice: Implement driver functionality to dump serdes equalizer values

[Simon Horman <horms@kernel.org>]

[ Fixed CC list by dropping '--cc=' from start of addresses. ]

On Thu, May 09, 2024 at 11:50:42PM -0700, Anil Samal wrote:
> To debug link issues in the field, serdes Tx/Rx equalizer values
> help to determine the health of serdes lane.
> 
> Extend 'ethtool -d' option to dump serdes Tx/Rx equalizer.
> The following list of equalizer param is supported
>     a. rx_equalization_pre2
>     b. rx_equalization_pre1
>     c. rx_equalization_post1
>     d. rx_equalization_bflf
>     e. rx_equalization_bfhf
>     f. rx_equalization_drate
>     g. tx_equalization_pre1
>     h. tx_equalization_pre3
>     i. tx_equalization_atten
>     j. tx_equalization_post1
>     k. tx_equalization_pre2
> 
> Reviewed-by: Anthony L Nguyen <anthony.l.nguyen@intel.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Anil Samal <anil.samal@intel.com>

The nit below notwithstanding, this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

> diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c

...

> +/**
> + * ice_get_extended_regs - returns FEC correctable, uncorrectable stats per
> + *                         pcsquad, pcsport
> + * @netdev: pointer to net device structure
> + * @p: output buffer to fill requested register dump
> + *
> + * Return: 0 on success, negative on failure.
> + */
> +static int ice_get_extended_regs(struct net_device *netdev, void *p)
> +{
> +	struct ice_regdump_to_ethtool *ice_prv_regs_buf;
> +	struct ice_netdev_priv *np = netdev_priv(netdev);

nit: Please arrange local variables in reverse xmas tree order -
     longest line to shortest.

     It's probably not necessary to repost just because of this.

     This tool can be of use here: https://github.com/ecree-solarflare/xmastree

> +	struct ice_port_topology port_topology = {};
> +	struct ice_port_info *pi;
> +	struct ice_pf *pf;
> +	struct ice_hw *hw;
> +	unsigned int i;
> +	int err;

...