From: Simon Horman <horms@kernel.org>
To: Xiaolei Wang <xiaolei.wang@windriver.com>
Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mcoquelin.stm32@gmail.com,
richardcochran@gmail.com, bartosz.golaszewski@linaro.org,
rohan.g.thomas@intel.com, rmk+kernel@armlinux.org.uk,
fancer.lancer@gmail.com, ahalaney@redhat.com,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [net PATCH v5 2/2] net: stmmac: move the EST structure to struct stmmac_priv
Date: Sat, 11 May 2024 18:41:12 +0100 [thread overview]
Message-ID: <20240511174112.GS2347895@kernel.org> (raw)
In-Reply-To: <20240510122155.3394723-3-xiaolei.wang@windriver.com>
On Fri, May 10, 2024 at 08:21:55PM +0800, Xiaolei Wang wrote:
> Move the EST structure to struct stmmac_priv, because the
> EST configs don't look like platform config, but EST is
> enabled in runtime with the settings retrieved for the TC
> TAPRIO feature also in runtime. So it's better to have the
> EST-data preserved in the driver private data instead of
> the platform data storage.
>
> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
Patch 1/2 of this series is a fix for net, with a Fixes tag.
IMHO, it looks good.
This patch, however, is a clean-up/enhancement.
It doesn't have a Fixes tag, which is good.
But I think it should be targeted at net-next
(once patch 1/2 has been accepted into net, and
net has been merged into net-next; also, given the timing,
once net-next reopens as It's likely to close rather soon
for the merge window).
Perhaps it is possible for the maintainers to pick up
patch 1/2, leaving this patch as follow-up.
The above notwithstanding, this patch looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
--
pw-bot: under-review
next prev parent reply other threads:[~2024-05-11 17:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 12:21 [net PATCH v5 0/2] Move EST lock and EST structure to struct stmmac_priv Xiaolei Wang
2024-05-10 12:21 ` [net PATCH v5 1/2] net: stmmac: move the EST lock " Xiaolei Wang
2024-05-11 17:37 ` Simon Horman
2024-05-11 18:01 ` Serge Semin
2024-05-10 12:21 ` [net PATCH v5 2/2] net: stmmac: move the EST structure " Xiaolei Wang
2024-05-11 17:41 ` Simon Horman [this message]
2024-05-11 18:10 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240511174112.GS2347895@kernel.org \
--to=horms@kernel.org \
--cc=ahalaney@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rohan.g.thomas@intel.com \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).