From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: Joe Damato <jdamato@fastly.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
zyjzyj2000@gmail.com, nalramli@fastly.com,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
linux-rdma@vger.kernel.org (open list:MELLANOX MLX5 core VPI
driver)
Subject: Re: [PATCH net-next v2 1/1] net/mlx5e: Add per queue netdev-genl stats
Date: Mon, 13 May 2024 07:58:27 -0700 [thread overview]
Message-ID: <20240513075827.66d42cc1@kernel.org> (raw)
In-Reply-To: <20240510041705.96453-2-jdamato@fastly.com>
On Fri, 10 May 2024 04:17:04 +0000 Joe Damato wrote:
> Add functions to support the netdev-genl per queue stats API.
>
> ./cli.py --spec netlink/specs/netdev.yaml \
> --dump qstats-get --json '{"scope": "queue"}'
>
> ...snip
>
> {'ifindex': 7,
> 'queue-id': 62,
> 'queue-type': 'rx',
> 'rx-alloc-fail': 0,
> 'rx-bytes': 105965251,
> 'rx-packets': 179790},
> {'ifindex': 7,
> 'queue-id': 0,
> 'queue-type': 'tx',
> 'tx-bytes': 9402665,
> 'tx-packets': 17551},
>
> ...snip
>
> Also tested with the script tools/testing/selftests/drivers/net/stats.py
> in several scenarios to ensure stats tallying was correct:
>
> - on boot (default queue counts)
> - adjusting queue count up or down (ethtool -L eth0 combined ...)
> - adding mqprio TCs
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
Tariq, could you take a look? Is it good enough to make 6.10?
Would be great to have it..
next prev parent reply other threads:[~2024-05-13 14:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 4:17 [PATCH net-next v2 0/1] mlx5: Add netdev-genl queue stats Joe Damato
2024-05-10 4:17 ` [PATCH net-next v2 1/1] net/mlx5e: Add per queue netdev-genl stats Joe Damato
2024-05-13 14:58 ` Jakub Kicinski [this message]
2024-05-13 17:33 ` Joe Damato
2024-05-13 18:46 ` Joe Damato
2024-05-13 18:55 ` Jakub Kicinski
2024-05-14 18:44 ` Tariq Toukan
2024-05-14 19:17 ` Joe Damato
2024-05-15 7:19 ` Joe Damato
2024-05-23 7:27 ` Tariq Toukan
2024-05-23 23:14 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513075827.66d42cc1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nalramli@fastly.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).