From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
thepacketgeek@gmail.com, Aijay Adams <aijay@meta.com>,
netdev@vger.kernel.org (open list:NETWORKING DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net-next] netconsole: Do not shutdown dynamic configuration if cmdline is invalid
Date: Mon, 13 May 2024 14:51:29 -0700 [thread overview]
Message-ID: <20240513145129.6f094f92@kernel.org> (raw)
In-Reply-To: <20240510103005.3001545-1-leitao@debian.org>
On Fri, 10 May 2024 03:30:05 -0700 Breno Leitao wrote:
> +static inline bool dynamic_netconsole_enabled(void)
> +{
> + return IS_ENABLED(CONFIG_NETCONSOLE_DYNAMIC);
> +}
Why the separate static inline?
We can put IS_ENABLED.. directly in the if condition.
next prev parent reply other threads:[~2024-05-13 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:30 [PATCH net-next] netconsole: Do not shutdown dynamic configuration if cmdline is invalid Breno Leitao
2024-05-13 21:51 ` Jakub Kicinski [this message]
2024-05-14 12:06 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513145129.6f094f92@kernel.org \
--to=kuba@kernel.org \
--cc=aijay@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thepacketgeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).