netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Berger <opendmb@gmail.com>
To: stable@vger.kernel.org
Cc: Doug Berger <opendmb@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH stable 5.4 0/2] net: bcmgenet: revisit MAC reset
Date: Thu, 16 May 2024 14:11:51 -0700	[thread overview]
Message-ID: <20240516211153.140679-1-opendmb@gmail.com> (raw)

Commit 3a55402c9387 ("net: bcmgenet: use RGMII loopback for MAC
reset") was intended to resolve issues with reseting the UniMAC
core within the GENET block by providing better control over the
clocks used by the UniMAC core. Unfortunately, it is not
compatible with all of the supported system configurations so an
alternative method must be applied.

This commit set provides such an alternative. The first commit
reverts the previous change and the second commit provides the
alternative reset sequence that addresses the concerns observed
with the previous implementation.

This replacement implementation should be applied to the stable
branches wherever commit 3a55402c9387 ("net: bcmgenet: use RGMII
loopback for MAC reset") has been applied.

Unfortunately, reverting that commit may conflict with some
restructuring changes introduced by commit 4f8d81b77e66 ("net:
bcmgenet: Refactor register access in bcmgenet_mii_config").
The first commit in this set has been manually edited to
resolve the conflict on stable/linux-5.4.y.

Doug Berger (2):
  Revert "net: bcmgenet: use RGMII loopback for MAC reset"
  net: bcmgenet: keep MAC in reset until PHY is up

 .../net/ethernet/broadcom/genet/bcmgenet.c    | 10 ++---
 .../ethernet/broadcom/genet/bcmgenet_wol.c    |  6 ++-
 drivers/net/ethernet/broadcom/genet/bcmmii.c  | 39 +++----------------
 3 files changed, 16 insertions(+), 39 deletions(-)

-- 
2.34.1


             reply	other threads:[~2024-05-16 21:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16 21:11 Doug Berger [this message]
2024-05-16 21:11 ` [PATCH stable 5.4 1/2] Revert "net: bcmgenet: use RGMII loopback for MAC reset" Doug Berger
2024-05-16 21:11 ` [PATCH stable 5.4 2/2] net: bcmgenet: keep MAC in reset until PHY is up Doug Berger
2024-05-23 11:29 ` [PATCH stable 5.4 0/2] net: bcmgenet: revisit MAC reset Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516211153.140679-1-opendmb@gmail.com \
    --to=opendmb@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).