From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5B4F13E88B; Fri, 17 May 2024 19:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715973288; cv=none; b=AodruRP32Z2Q+ErsuDJz0HnamVcKkoqCo5ef0W+yCQ4gnMKLNRbvKnoaPyG/pYs4L5wiF94aGsGZF40D02f0e3/sPnMmksw5/3uAOm1+TZx1xvQvLi4SV8bqa6io2AkzfSJA89KdyYuXXPmdhiq9gB5VnQ+6h+A3YMl7d+pyWUY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715973288; c=relaxed/simple; bh=hLpMPC+/AppxDcAV2ufGcWfezjmaBBhECN+D8I44Deo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CDuBAok0cOA8KSVlWggMV2o/5B7RwXuuU3bOnhS4HlS0zGanFTJYqTg4a8XZVsnbt4dg+0LvhzmjG39bI7mUJQcWsiYyd25m96ebSBZ4OYzBb0jol7bAAMsWo6sty9TiKiMRmu1k5qFgMlRtS1GgDkDq/mtDTokkAKNPfLv9ztw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HhcfD82G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HhcfD82G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 521FCC32781; Fri, 17 May 2024 19:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715973288; bh=hLpMPC+/AppxDcAV2ufGcWfezjmaBBhECN+D8I44Deo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HhcfD82Gk3Wtxgx+VlyJV/rSrpV/exhOuCj90yeoOf8VzcONakHmH45Dpx/qxv9xJ M3qHNRnFxpmTmNcEkUewuU3CPo///EOr0JN9euO3kiDirr4EZph9pU2tbke45zFvW3 KFcOs4X+Xy+zWVyJLNmZcc7y1dT7Ph5iL8h5PoMatpzF0Jte+NEyIqt4RU65xhfkXF ob7iMioJ8gct4aSfpLtT96VyKPJpXUReDhvqKj0RV46xBi5G5899nUDaP/TIw2g3XC GOM6me//sqTVBgIYOjAQhEZhjW6S0B9e5g1mov2w0PwDcEppyoX3Fse5/YyIyANa7b CEE43RPUsjveQ== Date: Fri, 17 May 2024 12:14:47 -0700 From: Jakub Kicinski To: Ronald Wahl Cc: Ronald Wahl , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] net: ks8851: Fix another TX stall caused by wrong ISR flag handling Message-ID: <20240517121447.4fb122d8@kernel.org> In-Reply-To: <20240513143922.1330122-1-rwahl@gmx.de> References: <20240513143922.1330122-1-rwahl@gmx.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 13 May 2024 16:39:22 +0200 Ronald Wahl wrote: > Under some circumstances it may happen that the ks8851 Ethernet driver > stops sending data. > > Currently the interrupt handler resets the interrupt status flags in the > hardware after handling TX. With this approach we may lose interrupts in > the time window between handling the TX interrupt and resetting the TX > interrupt status bit. Thanks! This is commit 317a215d4932 ("net: ks8851: Fix another TX stall caused by wrong ISR flag handling") in net. Looks like bot didn't respond.