From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: <mhal@rbox.co>, <davem@davemloft.net>, <edumazet@google.com>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>, <shuah@kernel.org>
Subject: Re: [PATCH net v2 1/2] af_unix: Fix garbage collection of embryos carrying OOB with SCM_RIGHTS
Date: Fri, 17 May 2024 12:24:19 -0700 [thread overview]
Message-ID: <20240517122419.0c9a0539@kernel.org> (raw)
In-Reply-To: <20240517074742.24709-1-kuniyu@amazon.com>
On Fri, 17 May 2024 16:47:42 +0900 Kuniyuki Iwashima wrote:
> From: Michal Luczaj <mhal@rbox.co>
> Date: Fri, 17 May 2024 07:59:16 +0200
> > One question: git send-email automatically adds my Signed-off-by to your
> > patch (patch 2/2 in this series). Should I leave it that way?
>
> SOB is usually added by someone who changed the diff or merged it.
>
> I think it would be better not to add it if not intended.
My understanding is that Michal should indeed add his SOB, as he is
the one submitting the patch now, and from the "certificate of origin"
we need his assurance that the code is indeed released under the
appropriate license.
If you could reply to your own posting with the SoB, Michal, that'd be
enough.
next prev parent reply other threads:[~2024-05-17 19:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 14:50 [PATCH net v2 0/2] af_unix: Fix GC and improve selftest Michal Luczaj
2024-05-16 14:50 ` [PATCH net v2 1/2] af_unix: Fix garbage collection of embryos carrying OOB with SCM_RIGHTS Michal Luczaj
2024-05-17 1:45 ` Kuniyuki Iwashima
2024-05-17 5:59 ` Michal Luczaj
2024-05-17 7:47 ` Kuniyuki Iwashima
2024-05-17 8:55 ` Michal Luczaj
2024-05-17 9:22 ` Kuniyuki Iwashima
2024-05-17 9:58 ` Michal Luczaj
2024-05-17 19:24 ` Jakub Kicinski [this message]
2024-05-19 8:47 ` Michal Luczaj
2024-05-16 14:50 ` [PATCH net v2 2/2] selftest: af_unix: Make SCM_RIGHTS into OOB data Michal Luczaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517122419.0c9a0539@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuniyu@amazon.com \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).