From: Simon Horman <horms@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ken Milmore <ken.milmore@gmail.com>
Subject: Re: [PATCH net] Revert "r8169: don't try to disable interrupts if NAPI is, scheduled already"
Date: Mon, 20 May 2024 20:54:42 +0100 [thread overview]
Message-ID: <20240520195442.GC764145@kernel.org> (raw)
In-Reply-To: <af817788-d933-4cde-8bea-942397fd26fe@gmail.com>
On Mon, May 20, 2024 at 03:50:11PM +0200, Heiner Kallweit wrote:
> On 15.05.2024 08:18, Heiner Kallweit wrote:
> > This reverts commit 7274c4147afbf46f45b8501edbdad6da8cd013b9.
> >
> > Ken reported that RTL8125b can lock up if gro_flush_timeout has the
> > default value of 20000 and napi_defer_hard_irqs is set to 0.
> > In this scenario device interrupts aren't disabled, what seems to
> > trigger some silicon bug under heavy load. I was able to reproduce this
> > behavior on RTL8168h. Fix this by reverting 7274c4147afb.
> >
> > Fixes: 7274c4147afb ("r8169: don't try to disable interrupts if NAPI is scheduled already")
> > Cc: stable@vger.kernel.org
> > Reported-by: Ken Milmore <ken.milmore@gmail.com>
> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > ---
>
> This patch was mistakenly set to "changes requested".
> The replies from Ken provide additional details on how interrupt mask
> and status register behave on these chips. However the patch itself
> is correct and should be applied.
I guess someone hit the wrong button by mistake.
Let's see if this puts things back on track.
pw-bot: under-review
next prev parent reply other threads:[~2024-05-20 19:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 6:18 [PATCH net] Revert "r8169: don't try to disable interrupts if NAPI is, scheduled already" Heiner Kallweit
2024-05-15 12:23 ` Eric Dumazet
2024-05-16 21:10 ` Ken Milmore
2024-05-16 21:31 ` Ken Milmore
2024-05-20 13:50 ` Heiner Kallweit
2024-05-20 15:55 ` Ken Milmore
2024-05-20 19:54 ` Simon Horman [this message]
2024-05-21 9:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240520195442.GC764145@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=ken.milmore@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).