* [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061
@ 2024-05-21 6:54 Mathieu Othacehe
2024-05-23 9:53 ` Paolo Abeni
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Mathieu Othacehe @ 2024-05-21 6:54 UTC (permalink / raw)
To: Andrew Lunn, Heiner Kallweit, Russell King, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Florian Fainelli
Cc: netdev, linux-kernel, Mathieu Othacehe, Karim Ben Houcine
Following a similar reinstate for the KSZ8081 and KSZ9031.
Older kernels would use the genphy_soft_reset if the PHY did not implement
a .soft_reset.
The KSZ8061 errata described here:
https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8061-Errata-DS80000688B.pdf
and worked around with 232ba3a51c ("net: phy: Micrel KSZ8061: link failure after cable connect")
is back again without this soft reset.
Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
Tested-by: Karim Ben Houcine <karim.benhoucine@landisgyr.com>
Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
---
drivers/net/phy/micrel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 13e30ea7eec5..1d769322b059 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -5327,6 +5327,7 @@ static struct phy_driver ksphy_driver[] = {
/* PHY_BASIC_FEATURES */
.probe = kszphy_probe,
.config_init = ksz8061_config_init,
+ .soft_reset = genphy_soft_reset,
.config_intr = kszphy_config_intr,
.handle_interrupt = kszphy_handle_interrupt,
.suspend = kszphy_suspend,
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061
2024-05-21 6:54 [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061 Mathieu Othacehe
@ 2024-05-23 9:53 ` Paolo Abeni
2024-05-23 14:15 ` Andrew Lunn
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Paolo Abeni @ 2024-05-23 9:53 UTC (permalink / raw)
To: Mathieu Othacehe, Andrew Lunn, Heiner Kallweit, Russell King,
David S . Miller, Eric Dumazet, Jakub Kicinski, Florian Fainelli
Cc: netdev, linux-kernel, Karim Ben Houcine
On Tue, 2024-05-21 at 08:54 +0200, Mathieu Othacehe wrote:
> Following a similar reinstate for the KSZ8081 and KSZ9031.
>
> Older kernels would use the genphy_soft_reset if the PHY did not implement
> a .soft_reset.
>
> The KSZ8061 errata described here:
> https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8061-Errata-DS80000688B.pdf
> and worked around with 232ba3a51c ("net: phy: Micrel KSZ8061: link failure after cable connect")
> is back again without this soft reset.
>
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Tested-by: Karim Ben Houcine <karim.benhoucine@landisgyr.com>
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
LGTM, but waiting a little longer for anyone from phy crew to ack it.
Thanks,
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061
2024-05-21 6:54 [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061 Mathieu Othacehe
2024-05-23 9:53 ` Paolo Abeni
@ 2024-05-23 14:15 ` Andrew Lunn
2024-05-23 15:30 ` Florian Fainelli
2024-05-24 11:40 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2024-05-23 14:15 UTC (permalink / raw)
To: Mathieu Othacehe
Cc: Heiner Kallweit, Russell King, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Florian Fainelli, netdev,
linux-kernel, Karim Ben Houcine
On Tue, May 21, 2024 at 08:54:06AM +0200, Mathieu Othacehe wrote:
> Following a similar reinstate for the KSZ8081 and KSZ9031.
>
> Older kernels would use the genphy_soft_reset if the PHY did not implement
> a .soft_reset.
>
> The KSZ8061 errata described here:
> https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8061-Errata-DS80000688B.pdf
> and worked around with 232ba3a51c ("net: phy: Micrel KSZ8061: link failure after cable connect")
> is back again without this soft reset.
>
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Tested-by: Karim Ben Houcine <karim.benhoucine@landisgyr.com>
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061
2024-05-21 6:54 [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061 Mathieu Othacehe
2024-05-23 9:53 ` Paolo Abeni
2024-05-23 14:15 ` Andrew Lunn
@ 2024-05-23 15:30 ` Florian Fainelli
2024-05-24 11:40 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2024-05-23 15:30 UTC (permalink / raw)
To: Mathieu Othacehe, Andrew Lunn, Heiner Kallweit, Russell King,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: netdev, linux-kernel, Karim Ben Houcine
On 5/20/2024 11:54 PM, Mathieu Othacehe wrote:
> Following a similar reinstate for the KSZ8081 and KSZ9031.
>
> Older kernels would use the genphy_soft_reset if the PHY did not implement
> a .soft_reset.
>
> The KSZ8061 errata described here:
> https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8061-Errata-DS80000688B.pdf
> and worked around with 232ba3a51c ("net: phy: Micrel KSZ8061: link failure after cable connect")
> is back again without this soft reset.
>
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Tested-by: Karim Ben Houcine <karim.benhoucine@landisgyr.com>
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061
2024-05-21 6:54 [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061 Mathieu Othacehe
` (2 preceding siblings ...)
2024-05-23 15:30 ` Florian Fainelli
@ 2024-05-24 11:40 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-05-24 11:40 UTC (permalink / raw)
To: Mathieu Othacehe
Cc: andrew, hkallweit1, linux, davem, edumazet, kuba, pabeni,
f.fainelli, netdev, linux-kernel, karim.benhoucine
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 21 May 2024 08:54:06 +0200 you wrote:
> Following a similar reinstate for the KSZ8081 and KSZ9031.
>
> Older kernels would use the genphy_soft_reset if the PHY did not implement
> a .soft_reset.
>
> The KSZ8061 errata described here:
> https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8061-Errata-DS80000688B.pdf
> and worked around with 232ba3a51c ("net: phy: Micrel KSZ8061: link failure after cable connect")
> is back again without this soft reset.
>
> [...]
Here is the summary with links:
- net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061
https://git.kernel.org/netdev/net/c/128d54fbcb14
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-05-24 11:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-21 6:54 [PATCH] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8061 Mathieu Othacehe
2024-05-23 9:53 ` Paolo Abeni
2024-05-23 14:15 ` Andrew Lunn
2024-05-23 15:30 ` Florian Fainelli
2024-05-24 11:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).