* [PATCH net v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work()
@ 2024-05-21 15:34 Ryosuke Yasuoka
2024-05-21 15:54 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ryosuke Yasuoka @ 2024-05-21 15:34 UTC (permalink / raw)
To: krzk, davem, edumazet, kuba, pabeni, horms
Cc: Ryosuke Yasuoka, netdev, linux-kernel, syoshida
When nci_rx_work() receives a zero-length payload packet, it should not
discard the packet and exit the loop. Instead, it should continue
processing subsequent packets.
Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet")
Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>
---
v3
- Remove inappropriate Reported-by tag
v2
- Fix commit msg to be clearer to say
- Remove inappropriate Closes tag
net/nfc/nci/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
index 7a9897fbf4f4..f456a5911e7d 100644
--- a/net/nfc/nci/core.c
+++ b/net/nfc/nci/core.c
@@ -1531,8 +1531,7 @@ static void nci_rx_work(struct work_struct *work)
if (!nci_valid_size(skb)) {
kfree_skb(skb);
- kcov_remote_stop();
- break;
+ continue;
}
/* Process frame */
--
2.44.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work()
2024-05-21 15:34 [PATCH net v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work() Ryosuke Yasuoka
@ 2024-05-21 15:54 ` Simon Horman
2024-05-21 16:42 ` Krzysztof Kozlowski
2024-05-23 10:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2024-05-21 15:54 UTC (permalink / raw)
To: Ryosuke Yasuoka
Cc: krzk, davem, edumazet, kuba, pabeni, netdev, linux-kernel,
syoshida
On Wed, May 22, 2024 at 12:34:42AM +0900, Ryosuke Yasuoka wrote:
> When nci_rx_work() receives a zero-length payload packet, it should not
> discard the packet and exit the loop. Instead, it should continue
> processing subsequent packets.
>
> Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet")
> Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>
> ---
> v3
> - Remove inappropriate Reported-by tag
>
> v2
> - Fix commit msg to be clearer to say
> - Remove inappropriate Closes tag
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work()
2024-05-21 15:34 [PATCH net v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work() Ryosuke Yasuoka
2024-05-21 15:54 ` Simon Horman
@ 2024-05-21 16:42 ` Krzysztof Kozlowski
2024-05-23 10:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-21 16:42 UTC (permalink / raw)
To: Ryosuke Yasuoka, davem, edumazet, kuba, pabeni, horms
Cc: netdev, linux-kernel, syoshida
On 21/05/2024 17:34, Ryosuke Yasuoka wrote:
> When nci_rx_work() receives a zero-length payload packet, it should not
> discard the packet and exit the loop. Instead, it should continue
> processing subsequent packets.
>
> Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet")
> Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>
> ---
> v3
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work()
2024-05-21 15:34 [PATCH net v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work() Ryosuke Yasuoka
2024-05-21 15:54 ` Simon Horman
2024-05-21 16:42 ` Krzysztof Kozlowski
@ 2024-05-23 10:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-05-23 10:50 UTC (permalink / raw)
To: Ryosuke Yasuoka
Cc: krzk, davem, edumazet, kuba, pabeni, horms, netdev, linux-kernel,
syoshida
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 22 May 2024 00:34:42 +0900 you wrote:
> When nci_rx_work() receives a zero-length payload packet, it should not
> discard the packet and exit the loop. Instead, it should continue
> processing subsequent packets.
>
> Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet")
> Signed-off-by: Ryosuke Yasuoka <ryasuoka@redhat.com>
>
> [...]
Here is the summary with links:
- [net,v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work()
https://git.kernel.org/netdev/net/c/6671e352497c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-23 10:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-21 15:34 [PATCH net v3] nfc: nci: Fix handling of zero-length payload packets in nci_rx_work() Ryosuke Yasuoka
2024-05-21 15:54 ` Simon Horman
2024-05-21 16:42 ` Krzysztof Kozlowski
2024-05-23 10:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).