netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints
@ 2024-05-23 17:17 Rob Herring (Arm)
  2024-05-24  7:39 ` Kory Maincent
  2024-05-28  0:00 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-05-23 17:17 UTC (permalink / raw)
  To: Oleksij Rempel, Kory Maincent, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Krzysztof Kozlowski, Conor Dooley,
	Andrew Lunn
  Cc: netdev, devicetree, linux-kernel

The child nodes are missing "additionalProperties" constraints which
means any undocumented properties or child nodes are allowed. Add the
constraints and all the undocumented properties exposed by the fix.

Fixes: f562202fedad ("dt-bindings: net: pse-pd: Add bindings for TPS23881 PSE controller")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../bindings/net/pse-pd/ti,tps23881.yaml       | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml b/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml
index 4147adb11e10..6992d56832bf 100644
--- a/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml
+++ b/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml
@@ -29,13 +29,31 @@ properties:
       of the ports conversion matrix that establishes relationship between
       the logical ports and the physical channels.
     type: object
+    additionalProperties: false
+
+    properties:
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 0
 
     patternProperties:
       '^channel@[0-7]$':
         type: object
+        additionalProperties: false
+
+        properties:
+          reg:
+            maxItems: 1
+
         required:
           - reg
 
+    required:
+      - "#address-cells"
+      - "#size-cells"
+
 unevaluatedProperties: false
 
 required:
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints
  2024-05-23 17:17 [PATCH net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints Rob Herring (Arm)
@ 2024-05-24  7:39 ` Kory Maincent
  2024-05-28  0:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Kory Maincent @ 2024-05-24  7:39 UTC (permalink / raw)
  To: Rob Herring (Arm)
  Cc: Oleksij Rempel, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Krzysztof Kozlowski, Conor Dooley, Andrew Lunn,
	netdev, devicetree, linux-kernel

On Thu, 23 May 2024 12:17:50 -0500
"Rob Herring (Arm)" <robh@kernel.org> wrote:

> The child nodes are missing "additionalProperties" constraints which
> means any undocumented properties or child nodes are allowed. Add the
> constraints and all the undocumented properties exposed by the fix.

Acked-by: Kory Maincent <kory.maincent@bootlin.com>

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints
  2024-05-23 17:17 [PATCH net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints Rob Herring (Arm)
  2024-05-24  7:39 ` Kory Maincent
@ 2024-05-28  0:00 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-05-28  0:00 UTC (permalink / raw)
  To: Rob Herring
  Cc: o.rempel, kory.maincent, davem, edumazet, kuba, pabeni, krzk+dt,
	conor+dt, andrew, netdev, devicetree, linux-kernel

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 23 May 2024 12:17:50 -0500 you wrote:
> The child nodes are missing "additionalProperties" constraints which
> means any undocumented properties or child nodes are allowed. Add the
> constraints and all the undocumented properties exposed by the fix.
> 
> Fixes: f562202fedad ("dt-bindings: net: pse-pd: Add bindings for TPS23881 PSE controller")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints
    https://git.kernel.org/netdev/net/c/12f86b9af96a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-05-28  0:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 17:17 [PATCH net] dt-bindings: net: pse-pd: ti,tps23881: Fix missing "additionalProperties" constraints Rob Herring (Arm)
2024-05-24  7:39 ` Kory Maincent
2024-05-28  0:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).