From: Leon Romanovsky <leon@kernel.org>
To: Greg Sword <gregsword0@gmail.com>
Cc: Haakon Bugge <haakon.bugge@oracle.com>,
Zhu Yanjun <zyjzyj2000@gmail.com>,
OFED mailing list <linux-rdma@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
"rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Saeed Mahameed <saeedm@nvidia.com>,
Tariq Toukan <tariqt@nvidia.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Allison Henderson <allison.henderson@oracle.com>,
Manjunath Patil <manjunath.b.patil@oracle.com>,
Mark Zhang <markzhang@nvidia.com>,
Chuck Lever III <chuck.lever@oracle.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Yang Li <yang.lee@linux.alibaba.com>
Subject: Re: [PATCH v2 3/6] RDMA/cma: Brute force GFP_NOIO
Date: Sun, 26 May 2024 12:27:01 +0300 [thread overview]
Message-ID: <20240526092701.GA96190@unreal> (raw)
In-Reply-To: <CAEz=Lcvbc3O+PtDSLvGAgd5fmps8j69DDn+Mgm8UWMFMNSd8WA@mail.gmail.com>
On Fri, May 17, 2024 at 03:07:34AM +0800, Greg Sword wrote:
> On Thu, May 16, 2024 at 11:54 PM Haakon Bugge <haakon.bugge@oracle.com> wrote:
> >
> > Hi Yanjun,
> >
> >
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/maintainer-netdev.rst?h=v6.9#n376
> > >
> > > "
> > > Netdev has a convention for ordering local variables in functions.
> > > Order the variable declaration lines longest to shortest, e.g.::
> >
> > "Infiniband subsystem" != netdev, right?
>
> All kernel subsystems should follow this rule, including the network
> and rdma subsystems
Of course not. The request to sort variables is netdev coding style,
rest of the kernel doesn't have this rule and doesn't care about it.
In Infiniband, we accept both styles, just to make sure that people who
submit their patches to both subsystems won't need to bother themselves
with this.
Thanks
>
> >
> >
> > Thxs, Håkon
> >
next prev parent reply other threads:[~2024-05-26 9:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 12:53 [PATCH v2 0/6] rds: rdma: Add ability to force GFP_NOIO Håkon Bugge
2024-05-15 12:53 ` [PATCH v2 1/6] workqueue: Inherit NOIO and NOFS alloc flags Håkon Bugge
2024-05-15 16:54 ` Tejun Heo
2024-05-16 15:27 ` Haakon Bugge
2024-05-16 16:29 ` Tejun Heo
2024-05-21 14:02 ` Haakon Bugge
2024-05-15 12:53 ` [PATCH v2 2/6] rds: Brute force GFP_NOIO Håkon Bugge
2024-05-15 12:53 ` [PATCH v2 3/6] RDMA/cma: " Håkon Bugge
2024-05-16 7:37 ` Zhu Yanjun
2024-05-16 15:49 ` Haakon Bugge
2024-05-16 19:07 ` Greg Sword
2024-05-17 9:28 ` Haakon Bugge
2024-05-26 9:27 ` Leon Romanovsky [this message]
2024-05-15 12:53 ` [PATCH v2 4/6] RDMA/cm: " Håkon Bugge
2024-05-15 12:53 ` [PATCH v2 5/6] RDMA/mlx5: " Håkon Bugge
2024-05-15 12:53 ` [PATCH v2 6/6] net/mlx5: " Håkon Bugge
2024-05-21 14:24 ` [PATCH v2 0/6] rds: rdma: Add ability to " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240526092701.GA96190@unreal \
--to=leon@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregsword0@gmail.com \
--cc=haakon.bugge@oracle.com \
--cc=jgg@ziepe.ca \
--cc=jiangshanlai@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=manjunath.b.patil@oracle.com \
--cc=markzhang@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=saeedm@nvidia.com \
--cc=shiraz.saleem@intel.com \
--cc=tariqt@nvidia.com \
--cc=tj@kernel.org \
--cc=yang.lee@linux.alibaba.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).