From: Jakub Kicinski <kuba@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
jiri@resnulli.us
Subject: Re: [PATCH iwl-net v2] ice: Add support for devlink loopback param.
Date: Tue, 28 May 2024 12:16:58 -0700 [thread overview]
Message-ID: <20240528121658.0bb99e8e@kernel.org> (raw)
In-Reply-To: <20240528110132.483447-1-wojciech.drewek@intel.com>
On Tue, 28 May 2024 13:01:32 +0200 Wojciech Drewek wrote:
> Subject: [PATCH iwl-net v2] ice: Add support for devlink loopback param.
iwl-next, presumably
Param makes sense, although the name keeps giving me pause.
I expect "loopback" will control either port loopback or something
like hairpin. Would "local-forwarding" not be a better name?
Not a big deal, I guess.
> + ``enabled`` - loopback traffic is not allowed on port
> +
> + ``disabled`` - loopback traffic is allowed on this port
The meaning seems inverted?
prev parent reply other threads:[~2024-05-28 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 11:01 [PATCH iwl-net v2] ice: Add support for devlink loopback param Wojciech Drewek
2024-05-28 11:40 ` Mateusz Polchlopek
2024-05-28 19:16 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528121658.0bb99e8e@kernel.org \
--to=kuba@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).