From: Jakub Kicinski <kuba@kernel.org>
To: Kevin Yang <yyd@google.com>
Cc: David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Neal Cardwell <ncardwell@google.com>,
Yuchung Cheng <ycheng@google.com>
Subject: Re: [PATCH net-next 2/2] tcp: add sysctl_tcp_rto_min_us
Date: Wed, 29 May 2024 16:47:04 -0700 [thread overview]
Message-ID: <20240529164704.49b39fb8@kernel.org> (raw)
In-Reply-To: <20240528171320.1332292-3-yyd@google.com>
On Tue, 28 May 2024 17:13:20 +0000 Kevin Yang wrote:
> + icsk->icsk_rto_min = usecs_to_jiffies(READ_ONCE(sock_net(sk)->
> + ipv4.sysctl_tcp_rto_min_us));
This is somewhat awkwardly broken into two lines.
Could you use a temp variable to save
rto_min_us = READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_rto_min_us);
?
Or just go over 80 chars, but preferably not. Chaining 3 calls in one
line is a bit Java-esque :S
With that feel free to add:
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
We also carry (a form of) this patch in Meta kernels.. :(
next prev parent reply other threads:[~2024-05-29 23:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 17:13 [PATCH net-next 0/2] tcp: add sysctl_tcp_rto_min_us Kevin Yang
2024-05-28 17:13 ` [PATCH net-next 1/2] tcp: derive delack_max with tcp_rto_min helper Kevin Yang
2024-05-28 17:13 ` [PATCH net-next 2/2] tcp: add sysctl_tcp_rto_min_us Kevin Yang
2024-05-29 23:47 ` Jakub Kicinski [this message]
2024-05-29 6:43 ` [PATCH net-next 0/2] " Jason Xing
2024-05-29 6:59 ` Jason Xing
2024-05-29 7:39 ` Eric Dumazet
2024-05-29 7:56 ` Tony Lu
2024-05-29 8:43 ` Jason Xing
2024-05-29 9:23 ` Eric Dumazet
2024-05-29 9:30 ` Jason Xing
2024-05-29 19:56 ` Kevin Yang
2024-05-29 7:21 ` Tony Lu
2024-05-29 8:49 ` Jason Xing
2024-05-30 1:08 ` Tony Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529164704.49b39fb8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
--cc=yyd@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).