From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next 11/15] net/mlx5e: SHAMPO, Add no-split ethtool counters for header/data split
Date: Wed, 29 May 2024 18:22:08 -0700 [thread overview]
Message-ID: <20240529182208.401b1ecf@kernel.org> (raw)
In-Reply-To: <20240528142807.903965-12-tariqt@nvidia.com>
On Tue, 28 May 2024 17:28:03 +0300 Tariq Toukan wrote:
> + * - `rx[i]_hds_nosplit_packets`
> + - Number of packets that were not split in modes that do header/data split
> + [#accel]_.
> + - Informative
> +
> + * - `rx[i]_hds_nosplit_bytes`
> + - Number of bytes that were not split in modes that do header/data split
> + [#accel]_.
> + - Informative
This is too vague. The ethtool HDS feature is for TCP only.
What does this count? Non-TCP packets basically?
Given this is a HW-GRO series, are HDS packets == HW-GRO eligible
packets?
next prev parent reply other threads:[~2024-05-30 1:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 14:27 [PATCH net-next 00/15] net/mlx5e: SHAMPO, Enable HW GRO once more Tariq Toukan
2024-05-28 14:27 ` [PATCH net-next 01/15] net/mlx5e: SHAMPO, Use net_prefetch API Tariq Toukan
2024-05-28 14:27 ` [PATCH net-next 02/15] net/mlx5e: SHAMPO, Fix incorrect page release Tariq Toukan
2024-05-30 1:12 ` Jakub Kicinski
2024-05-30 3:24 ` Saeed Mahameed
2024-05-28 14:27 ` [PATCH net-next 03/15] net/mlx5e: SHAMPO, Fix invalid WQ linked list unlink Tariq Toukan
2024-05-28 14:27 ` [PATCH net-next 04/15] net/mlx5e: SHAMPO, Fix FCS config when HW GRO on Tariq Toukan
2024-05-28 14:27 ` [PATCH net-next 05/15] net/mlx5e: SHAMPO, Disable gso_size for non GRO packets Tariq Toukan
2024-05-28 14:27 ` [PATCH net-next 06/15] net/mlx5e: SHAMPO, Simplify header page release in teardown Tariq Toukan
2024-05-28 14:27 ` [PATCH net-next 07/15] net/mlx5e: SHAMPO, Specialize mlx5e_fill_skb_data() Tariq Toukan
2024-05-28 14:28 ` [PATCH net-next 08/15] net/mlx5e: SHAMPO, Skipping on duplicate flush of the same SHAMPO SKB Tariq Toukan
2024-06-05 13:48 ` Simon Horman
2024-06-05 17:55 ` Dragos Tatulea
2024-06-06 13:59 ` Simon Horman
2024-05-28 14:28 ` [PATCH net-next 09/15] net/mlx5e: SHAMPO, Make GRO counters more precise Tariq Toukan
2024-05-28 14:28 ` [PATCH net-next 10/15] net/mlx5e: SHAMPO, Drop rx_gro_match_packets counter Tariq Toukan
2024-05-28 14:28 ` [PATCH net-next 11/15] net/mlx5e: SHAMPO, Add no-split ethtool counters for header/data split Tariq Toukan
2024-05-30 1:22 ` Jakub Kicinski [this message]
2024-05-30 3:32 ` Saeed Mahameed
2024-05-30 15:31 ` Jakub Kicinski
2024-06-03 12:46 ` Dragos Tatulea
2024-05-28 14:28 ` [PATCH net-next 12/15] net/mlx5e: SHAMPO, Add header-only ethtool counters for header data split Tariq Toukan
2024-05-28 14:28 ` [PATCH net-next 13/15] net/mlx5e: SHAMPO, Use KSMs instead of KLMs Tariq Toukan
2024-05-30 1:23 ` Jakub Kicinski
2024-05-30 3:26 ` Saeed Mahameed
2024-05-28 14:28 ` [PATCH net-next 14/15] net/mlx5e: SHAMPO, Re-enable HW-GRO Tariq Toukan
2024-05-28 14:28 ` [PATCH net-next 15/15] net/mlx5e: SHAMPO, Coalesce skb fragments to page size Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529182208.401b1ecf@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).