From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Michal Kubiak <michal.kubiak@intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>,
George Kuruvinakunnel <george.kuruvinakunnel@intel.com>,
Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: Re: [PATCH net 4/8] i40e: Fix XDP program unloading while removing the driver
Date: Wed, 29 May 2024 18:54:28 -0700 [thread overview]
Message-ID: <20240529185428.2fd13cd7@kernel.org> (raw)
In-Reply-To: <20240528-net-2024-05-28-intel-net-fixes-v1-4-dc8593d2bbc6@intel.com>
On Tue, 28 May 2024 15:06:07 -0700 Jacob Keller wrote:
> + /* Called from netdev unregister context. Unload the XDP program. */
> + if (vsi->netdev->reg_state == NETREG_UNREGISTERING) {
> + xdp_features_clear_redirect_target(vsi->netdev);
> + old_prog = xchg(&vsi->xdp_prog, NULL);
> + if (old_prog)
> + bpf_prog_put(old_prog);
> +
> + return 0;
> + }
This is not great. The netdevice is closed at this stage, why is the xdp
setup try to do work if the device is closed even when not
unregistering?
next prev parent reply other threads:[~2024-05-30 1:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 22:06 [PATCH net 0/8] Intel Wired LAN Driver Updates 2024-05-28 (e1000e, i40e, ice) Jacob Keller
2024-05-28 22:06 ` [PATCH net 1/8] e1000e: move force SMBUS near the end of enable_ulp function Jacob Keller
2024-05-28 22:06 ` [PATCH net 2/8] i40e: factoring out i40e_suspend/i40e_resume Jacob Keller
2024-05-28 22:06 ` [PATCH net 3/8] i40e: Fully suspend and resume IO operations in EEH case Jacob Keller
2024-05-28 22:06 ` [PATCH net 4/8] i40e: Fix XDP program unloading while removing the driver Jacob Keller
2024-05-30 1:54 ` Jakub Kicinski [this message]
2024-05-30 16:38 ` Jacob Keller
2024-06-05 15:00 ` Michal Kubiak
2024-06-05 19:29 ` Jakub Kicinski
2024-06-06 10:02 ` Michal Kubiak
2024-06-06 13:43 ` Jakub Kicinski
2024-06-11 18:52 ` Michal Kubiak
2024-05-28 22:06 ` [PATCH net 5/8] ice: fix 200G PHY types to link speed mapping Jacob Keller
2024-05-28 22:06 ` [PATCH net 6/8] ice: implement AQ download pkg retry Jacob Keller
2024-05-30 1:51 ` Jakub Kicinski
2024-05-30 16:50 ` Jacob Keller
2024-05-31 8:25 ` Wojciech Drewek
2024-05-28 22:06 ` [PATCH net 7/8] ice: fix reads from NVM Shadow RAM on E830 and E825-C devices Jacob Keller
2024-05-28 22:06 ` [PATCH net 8/8] ice: check for unregistering correct number of devlink params Jacob Keller
2024-05-30 2:00 ` [PATCH net 0/8] Intel Wired LAN Driver Updates 2024-05-28 (e1000e, i40e, ice) patchwork-bot+netdevbpf
2024-05-30 16:45 ` Jacob Keller
2024-05-30 16:58 ` Jakub Kicinski
2024-05-30 17:04 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529185428.2fd13cd7@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=george.kuruvinakunnel@intel.com \
--cc=jacob.e.keller@intel.com \
--cc=maciej.fijalkowski@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).