From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A90C674076 for ; Thu, 30 May 2024 07:55:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717055748; cv=none; b=eA2bLZOURTtFSVRfPfvAb88Kk82P3/60ZhsRMIY7/IWEpt9YRYp97wZUGkCVhRSC0hj+Jia4R/GdfCbOxsxazm89wSnaYlYvlWxQiVMkdY1p+3w23GBoW8Ltng+z+ePg14ri/oTmY6tLGInZq0HtB3EVcCxke9UjkrgrX/13ubk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717055748; c=relaxed/simple; bh=aTbMjVPTC8GXV/q5t+biiMKXiTweLG8tXz9RUUVAAC4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Rzh2k+1mp3orZCyyoiDLuS/r8v3XGYcLdbfMFdp4Yk1zW1wux0R6a0E61BjPp3+0Bf4QkkN3L5paZILVS5+jbhFxeYYbu4FYVl278K+O81+l1AsgJse+WzCKeKpa2vdSZM1aPuuDajdCbsHBK2Ll35gDKd4by+kaYj7kmi80dsI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MJHl6+dZ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MJHl6+dZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717055745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OeTb7oEj2cbUagJqckhiCADw6n46hzpmlEhiRtW4rVw=; b=MJHl6+dZzSHryDWJmTlG/8uPAi3tP1Ui+TH/RQ15kduj5Ar7T69uVG22cwIQGXLqIdJX2m Tt41wev0chMe82HrL9zxX5gs3wvLK4/A1caqWyXFMfamDrA4JMCvnxrN+/MEp6M7Frg/hv srfpXSaCoyZcgo02Ki/Ydp8yYfegmJQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-zif75zlGP9WtFK8XvBBoqQ-1; Thu, 30 May 2024 03:55:43 -0400 X-MC-Unique: zif75zlGP9WtFK8XvBBoqQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4201f100188so5392025e9.0 for ; Thu, 30 May 2024 00:55:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717055742; x=1717660542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OeTb7oEj2cbUagJqckhiCADw6n46hzpmlEhiRtW4rVw=; b=jlqpFIzoyviLjoyNg3H/c86hudYblnwhr8ArvH4g2XbiysARsCDaznJpjTjKM82n9B 1PZxPCzU92ccGnOB7NS/xBoedjR8hExy1HHVcMM6/LjlWco5irI85VcemN6KjQMz+3fE +4o5okZf95xG4zpjNXlK8Sd0byyyhRgVsH5A0aK5ziP/imVVihiisbXUOiAH5cuX7407 6vXQC4oHXaXXcIrL761EMgJLwBko8b3ctlAmav9XQbGJRcl6y5Gz5mW2CuaF8nbrKxYC 3AA1OG/2wCxQ8SKZTVRRDQkMHLmJm6b2AxvvmLuodjwwiKrKq9mv+7l/0r2tc3A/W+BK X4rw== X-Gm-Message-State: AOJu0YyovdaEPMSJLni/QJhdWyQt+P4BT9Vp83d5DH1LMTp6IX9HxZdy 7nNAf98wLSWgvDJfJ8n4G+pe2JZzBGp6XysLI9rW7jDwG7kYxXyhiHPuCMBT8upmd3syK1Hptdz jPlZ9K6DoHJ6uszK3SNbDcpWBJp4fLP8SfqRfkYvFyY4oswQ5obZDBA== X-Received: by 2002:a05:600c:46d1:b0:41c:2313:da92 with SMTP id 5b1f17b1804b1-421278158aemr17009665e9.4.1717055742287; Thu, 30 May 2024 00:55:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8HukkuvxeZ/smNud2JY7Qr6ffHwWhMWtkGft9V4+i+ULhflQAWD/DnZ3kmA1eTSQA+wTj8w== X-Received: by 2002:a05:600c:46d1:b0:41c:2313:da92 with SMTP id 5b1f17b1804b1-421278158aemr17009325e9.4.1717055741647; Thu, 30 May 2024 00:55:41 -0700 (PDT) Received: from redhat.com ([2a02:14f:179:fb20:c957:3427:ac94:f0a3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42127084ca2sm16602315e9.41.2024.05.30.00.55.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 00:55:40 -0700 (PDT) Date: Thu, 30 May 2024 03:55:35 -0400 From: "Michael S. Tsirkin" To: Xuan Zhuo Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jason Wang , Eugenio =?iso-8859-1?Q?P=E9rez?= , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , virtualization@lists.linux.dev, bpf@vger.kernel.org Subject: Re: [PATCH net-next v1 0/7] virtnet_net: prepare for af-xdp Message-ID: <20240530034921-mutt-send-email-mst@kernel.org> References: <20240530072649.102437-1-xuanzhuo@linux.alibaba.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240530072649.102437-1-xuanzhuo@linux.alibaba.com> On Thu, May 30, 2024 at 03:26:42PM +0800, Xuan Zhuo wrote: > This patch set prepares for supporting af-xdp zerocopy. > There is no feature change in this patch set. > I just want to reduce the patch num of the final patch set, > so I split the patch set. > > #1-#3 add independent directory for virtio-net > #4-#7 do some refactor, the sub-functions will be used by the subsequent commits > > Thanks. > > v1: > 1. resend for the new net-next merge window What I said at the time is I am fine adding xsk in a new file or just adding in same file working on a split later. Given this was a year ago and all we keep seing is "prepare" patches, I am inclined to say do it in the reverse order: add af-xdp first then do the split when it's clear there is not a lot of code sharing going on. > > Xuan Zhuo (7): > virtio_net: independent directory > virtio_net: move core structures to virtio_net.h > virtio_net: add prefix virtnet to all struct inside virtio_net.h > virtio_net: separate virtnet_rx_resize() > virtio_net: separate virtnet_tx_resize() > virtio_net: separate receive_mergeable > virtio_net: separate receive_buf > > MAINTAINERS | 2 +- > drivers/net/Kconfig | 9 +- > drivers/net/Makefile | 2 +- > drivers/net/virtio/Kconfig | 12 + > drivers/net/virtio/Makefile | 8 + > drivers/net/virtio/virtnet.h | 248 ++++++++ > .../{virtio_net.c => virtio/virtnet_main.c} | 536 ++++++------------ > 7 files changed, 454 insertions(+), 363 deletions(-) > create mode 100644 drivers/net/virtio/Kconfig > create mode 100644 drivers/net/virtio/Makefile > create mode 100644 drivers/net/virtio/virtnet.h > rename drivers/net/{virtio_net.c => virtio/virtnet_main.c} (94%) > > -- > 2.32.0.3.g01195cf9f