From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0A0B17618E; Thu, 30 May 2024 08:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717058408; cv=none; b=bAR0sq55aqOou+thVjMETXoIWG6P3Q1DvSnK5tcz6dePgHYgzVPpv64kMr+Q7Vplp/NbAyo4Tfzt7NmItC1pJpeViEpZF37X1DTIW4h9jZTGPKRHWKUuZFcLMIBMjLveixrBUsYuoiE+CRKThX2DVI2fjAum5vvyEBelTVkDZaE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717058408; c=relaxed/simple; bh=eJnXxqymnXa68XS6otpNw5yROUyZND8qNVk7GfyKNws=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m9UOG5RFoWO3Zx3xINpXRIukki2rnrws7+cN8jAXEYXFXuJdT4bvFkm0JMuluz7vvnwPsWIfjMAtwcbGvXK7RdHxCGQPQps6uqUaNA9QeGeIXnCiSU6AmW6qat1qgbOrP6vPxNylgjkhox+drrgippjN4U7LPGHe27jjJ3P/pAk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=d0rIp3dw; arc=none smtp.client-ip=217.70.183.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="d0rIp3dw" Received: by mail.gandi.net (Postfix) with ESMTPSA id CFA92E0005; Thu, 30 May 2024 08:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1717058403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=omuiVoMKbFAjZ0PI451uHKpDzHiao6GQBVCNywyqCw0=; b=d0rIp3dwWDkPeI36pKgJmeTsbVk+6usO8uzbZRctH7ben4reJklEBT8M76mOgJLzPWIGyF oxjNCAeDXbEknqNu6ZHSgQKyT9mJWZFPkgTHhy1Zd6R3obhGiV2GzQsxGNwQ4eyWGV15L8 qopz6wjjKfeHUEZU/WWX3aKgvMHTr4dxp8ZayFPK/5WxtNnwpO/WCNaBeSfcuQpM/T71oE 28JsyDUG5fspNUBfEV7/i6BN9dFLW8HcHFnJr3day5lmTTZEPrLvYKlAJbCI72j5JgyV9w 4bZn98tO0bRzHAkhtLqDMwq7IRYHgt0fuaYYiIBD+oqrTmURbAbUm7PWRmtgPg== Date: Thu, 30 May 2024 10:39:58 +0200 From: Kory Maincent To: Thomas Petazzoni Cc: Jakub Kicinski , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier , Rahul Rameshbabu Subject: Re: [PATCH net-next v13 09/14] net: Add the possibility to support a selected hwtstamp in netdevice Message-ID: <20240530103958.3cef71c0@kmaincent-XPS-13-7390> In-Reply-To: <20240529180556.0e500675@windsurf> References: <20240529-feature_ptp_netnext-v13-0-6eda4d40fa4f@bootlin.com> <20240529-feature_ptp_netnext-v13-9-6eda4d40fa4f@bootlin.com> <20240529082111.1a1cbf1e@kernel.org> <20240529175032.54070c60@kmaincent-XPS-13-7390> <20240529180556.0e500675@windsurf> Organization: bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: kory.maincent@bootlin.com On Wed, 29 May 2024 18:05:56 +0200 Thomas Petazzoni wrote: > On Wed, 29 May 2024 17:50:32 +0200 > Kory Maincent wrote: >=20 > > > ERROR: modpost: "ptp_clock_phydev" [drivers/net/phy/libphy.ko] undefi= ned! > > > =20 > >=20 > > Thanks for the report. > > Weird, it should be in builtin code. =20 >=20 > Right, but you don't have an EXPORT_SYMBOL() for it, as far as I can see. Arf I removed too much EXPORT_SYMBOL(). Need another version for the patch series then. I will wait review before sending it. Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com