From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52E9917C9E5; Thu, 30 May 2024 12:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717073643; cv=none; b=cTvy9mjrK3I8kXq1FI5QhrVvYwptDbI4Gimi6VtmA5t1yqR95B+ngpJnujVSVvTYMd57tJDtbvZ94vGdcbKLMZnN0UFEnbvROvcyXpHtwiz0xBXp9Rz54EFkWQGjPMzamshoubTxzUkOJ5vLldy/KqZBNVNBXW4XyxbPffoZpdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717073643; c=relaxed/simple; bh=F3lUDpXkkg1u1Y2GeIDaUK3xQK3ttNcJBGHRBMhMWw0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sR4r3cZWZGQN+4nfBtSeHkLiih6Wel38vneT2GtzQVqZS1tt+xRAhuE/JveJk3vP6wDHDtsLedHgk+wo8+Esa7np7WwZnjqeu1iojgLKGyXhT7NfcB1Q4+AC61BD352fubfkY/+PatYdaa/jQirr8izZo4DAY8T4sQLVt2dkwWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=GkDUW/Ri; arc=none smtp.client-ip=217.70.183.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="GkDUW/Ri" Received: by mail.gandi.net (Postfix) with ESMTPSA id C7B7540006; Thu, 30 May 2024 12:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1717073633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f+ttqbsSC7Mf0krLnfeQ88z6eFjeEfepuvZI0uIRmts=; b=GkDUW/RiMVgDGnGgeGDIBqIjxy1uL7fgZXm0U0PQH4UJpW0XPX2hjMuFGP72O6Gq7gELr7 uZFQ4E+kBFNGaO73dpNyfsRJjCEL+f5cyXqf55ht+zHvWlYrYVu66JpTjF1BWaZaFiWCBn Nc1goeE88WvTV93c69VmmxsEZPNf0CHc5MiKEYO2uzbNtcmXEVknfpaoWeQSVXyChO9P0f Fi/yuJbpxZpv6T1h+JUF/YMf1XkdEWfGfGJnZbLRQJ4//NS4y1lm1HjHLv6yBRWt1afUr1 BYdYq65E/E6gSooj3mU39R+Ws/tdYoXC+ByJdSNEgVJeNPl+CkGfkeg8ltkdig== Date: Thu, 30 May 2024 14:53:50 +0200 From: Kory Maincent To: Sai Krishna Gajula Cc: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , "UNGLinuxDriver@microchip.com" , Simon Horman , Vladimir Oltean , Thomas Petazzoni , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , Maxime Chevallier , Rahul Rameshbabu Subject: Re: [PATCH net-next v13 12/14] net: ptp: Move ptp_clock_index() to builtin symbol Message-ID: <20240530145350.6341746f@kmaincent-XPS-13-7390> In-Reply-To: References: <20240529-feature_ptp_netnext-v13-0-6eda4d40fa4f@bootlin.com> <20240529-feature_ptp_netnext-v13-12-6eda4d40fa4f@bootlin.com> Organization: bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: kory.maincent@bootlin.com Hello Sai, On Thu, 30 May 2024 11:23:10 +0000 Sai Krishna Gajula wrote: > > Move ptp_clock_index() to builtin symbols to prepare for supporting get= and > > set hardware timestamps from ethtool, which is builtin. > >=20 > > Signed-off-by: Kory Maincent > > } > > + > > +int ptp_clock_index(struct ptp_clock *ptp) { > > + return ptp->index; > > +} > > +EXPORT_SYMBOL(ptp_clock_index); > > =20 > Please check the "build_clang - FAILED", "build_32bit - FAILED" build err= ors. Could you be more explicit? Which config are you using? What is the build error? I don't really see how this patch can bring a 32bit or clang build error.=20 Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com