From: Jakub Kicinski <kuba@kernel.org>
To: Ronak Doshi <ronak.doshi@broadcom.com>
Cc: <netdev@vger.kernel.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 net-next 3/4] vmxnet3: add command to allow disabling of offloads
Date: Thu, 30 May 2024 18:05:20 -0700 [thread overview]
Message-ID: <20240530180520.74899d37@kernel.org> (raw)
In-Reply-To: <20240528233907.2674-4-ronak.doshi@broadcom.com>
On Tue, 28 May 2024 16:39:05 -0700 Ronak Doshi wrote:
> @@ -270,6 +270,14 @@ netdev_features_t vmxnet3_fix_features(struct net_device *netdev,
> if (!(features & NETIF_F_RXCSUM))
> features &= ~NETIF_F_LRO;
>
> + if ((features & NETIF_F_LRO) &&
> + (adapter->disabledOffloads & VMXNET3_OFFLOAD_LRO))
> + features &= ~NETIF_F_LRO;
> +
> + if ((features & (NETIF_F_TSO | NETIF_F_TSO6)) &&
> + (adapter->disabledOffloads & VMXNET3_OFFLOAD_TSO))
> + features &= ~(NETIF_F_TSO | NETIF_F_TSO6);
Why do you clear them in fix_features?
They are not declared as supported how can they get enabled?
--
pw-bot: cr
next prev parent reply other threads:[~2024-05-31 1:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 23:39 [PATCH v1 net-next 0/4] vmxnet3: upgrade to version 9 Ronak Doshi
2024-05-28 23:39 ` [PATCH v1 net-next 1/4] vmxnet3: prepare for version 9 changes Ronak Doshi
2024-05-28 23:39 ` [PATCH v1 net-next 2/4] vmxnet3: add latency measurement support in vmxnet3 Ronak Doshi
2024-05-31 1:09 ` Jakub Kicinski
2024-05-28 23:39 ` [PATCH v1 net-next 3/4] vmxnet3: add command to allow disabling of offloads Ronak Doshi
2024-05-31 1:05 ` Jakub Kicinski [this message]
2024-05-28 23:39 ` [PATCH v1 net-next 4/4] vmxnet3: update to version 9 Ronak Doshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240530180520.74899d37@kernel.org \
--to=kuba@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ronak.doshi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).